Integrating Iris GPU benchmarking with meerkat #41
Conversation
| @@ -25,6 +25,14 @@ | |||
| - role: attach_manila | |||
| - role: run_manila_storage_benchmark | |||
|
|
|||
| - hosts: all | |||
There was a problem hiding this comment.
This should be - hosts: gpu that way it will only be run when people want to run the GPU benchmarks
| - ./vars/gpu.yaml | ||
| roles: | ||
| - role: setup_iris | ||
| - role: update_machine |
There was a problem hiding this comment.
Can you update the machine before running other roles? That way we can make sure we have the latest versions of this installed.
| mkdir iris_bench | ||
| cd iris_bench | ||
|
|
||
| git clone https://github.com/bryceshirley/iris-bench.git |
There was a problem hiding this comment.
Can we change this to the new repo location?
https://github.com/Chris-green-stfc/iris-bench.git
| @@ -0,0 +1,2 @@ | |||
| - name: Run gpu benchmark | |||
| shell: "./gpu_benchmark.sh -p /home/{{ user }} -s local" | |||
There was a problem hiding this comment.
the bash script doesn't seem to take in any user inputs, so you don't need -p /home/{{ user }} -s local
|
|
||
| # Run Benchmark | ||
|
|
||
| iris-gpubench --benchmark_image "synthetic_regression" --export_to_meerkat |
There was a problem hiding this comment.
Is --export_to_meerkat something you've added to the IRIS benchmarking?
| #! /bin/bash | ||
|
|
||
| server_UUID=$(curl http://169.254.169.254/openstack/latest/meta_data.json -s | grep -ioP .{8}-.{4}-.{4}-.{4}-.{12}) | ||
| vm_info=$(openstack server show $server_UUID) | ||
| echo $vm_info | grep -ioP "\w*.nubes.rl.ac.uk" | head -1 | ||
| echo $vm_info | grep -ioP "flavor\s\|\s\S*" | cut -c 10- | ||
| echo $vm_info | grep -ioP "image\s\|\s\S*" | cut -c 9- |
There was a problem hiding this comment.
This file doesn't seem to be run. So does it need to be here?
| benchmark_and_send_data () { | ||
| run_benchmark | ||
| } |
There was a problem hiding this comment.
This doesn't send the data to meerkat, unless the --export_to_meerkat does that in the IRIS benchmark itself
|
|
||
| DB="https://{{ db_ip }}:{{ db_port }}/write" | ||
|
|
||
| cp get-iris.sh $storage_path |
There was a problem hiding this comment.
$storage doesn't seem to be a declared variable.
Does the file need to be copied anywhere? It should have already have been copied to ~/
| mode: '0755' | ||
| loop: | ||
| - get-iris.sh | ||
| - get-vm-info.sh |
There was a problem hiding this comment.
Does this file need to be copied? I don't think it is called at all
This PR integrates IRIS GPU benchmarking functionality into Meerkat.