Added Unix benchmark #32
Conversation
Added unix-bench for more CPU/system benchmarking
| bench1="${bench}_single_core" | ||
| bench2="${bench}_multi_core" | ||
| # Send data to DB | ||
| curl -H "Authorization: Basic `echo -n "{{ db_username }}:{{ db_password }}" | base64`" -d 'unix_bench,image='"$image"',flavor='"$flavor"' '"$bench1"'='"$r1"'' -X POST $DB --insecure |
There was a problem hiding this comment.
Could you add a comment about --insecure flag?
There was a problem hiding this comment.
If the host has an invalid cert we can get a proper DNS record and TLS certificate?
That way we don't have to use the --insecure flag going forward
| # Get VM infor | ||
| server_UUID=$(curl http://169.254.169.254/openstack/latest/meta_data.json -s | grep -ioP .{8}-.{4}-.{4}-.{4}-.{12}) | ||
| vm_info=$(openstack server show $server_UUID --os-cloud openstack) | ||
| #hypervisor=$(echo $vm_info | grep -ioP "\w*.nubes.rl.ac.uk" | head -1) |
There was a problem hiding this comment.
It is there in case we ever want HV information, but it requires admin creds to do so
uses --insecure due to self signed cert
| bench1="${bench}_single_core" | ||
| bench2="${bench}_multi_core" | ||
| # Send data to DB | ||
| curl -H "Authorization: Basic `echo -n "{{ db_username }}:{{ db_password }}" | base64`" -d 'unix_bench,image='"$image"',flavor='"$flavor"' '"$bench1"'='"$r1"'' -X POST $DB --insecure |
There was a problem hiding this comment.
If the host has an invalid cert we can get a proper DNS record and TLS certificate?
That way we don't have to use the --insecure flag going forward
| @@ -0,0 +1,72 @@ | |||
| #! /bin/bash | |||
|
|
|||
There was a problem hiding this comment.
set -euo pipefail so it will fail if something goes wrong
Additionally can we setup shell-check like so: https://github.com/stfc/SCD-OpenStack-Utils/blob/master/.github/workflows/gpu_benchmark.yaml#L11
Since this more scripts we add without linting the harder it will be in the future
|
|
||
| # Get VM infor | ||
| server_UUID=$(curl http://169.254.169.254/openstack/latest/meta_data.json -s | grep -ioP .{8}-.{4}-.{4}-.{4}-.{12}) | ||
| vm_info=$(openstack server show $server_UUID --os-cloud openstack) |
There was a problem hiding this comment.
Can we get this from the same meta_data.json or cloud-init which should contain all the relevant details rather than having to copy app creds to each VM
There was a problem hiding this comment.
Will address this in future PR
added pipefail and comment explaining --insecure to unix bench script
Added unix-bench for more CPU/system benchmarking