Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get prs #75

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Refactor get prs #75

wants to merge 5 commits into from

Conversation

khalford
Copy link
Member

@khalford khalford commented Nov 19, 2024

Re-Write of the GitHub pull request collection functionality.

Moved JSON request data serialisation into the dataclass itself.
Checking for stale pull requests after collecting them.
Option to sort pull requests by properties

Now: utilising serialisation inside of dataclasses, checking for stale pull requests after collecting them and sorting by age before handing over
@khalford khalford added the minor Semver minor change label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 99.25373% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.89%. Comparing base (fe0e2b2) to head (dd2e9c8).

Files with missing lines Patch % Lines
cloud-chatops/tests/test_find_prs.py 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   96.25%   95.89%   -0.36%     
==========================================
  Files          19       19              
  Lines         802      756      -46     
==========================================
- Hits          772      725      -47     
- Misses         30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Semver minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant