(Closes #2624) Add FortranWriter().schedule_node().
#2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2628 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 356 356
Lines 48438 48454 +16
=======================================
+ Hits 48373 48389 +16
Misses 65 65 ☔ View full report in Codecov by Sentry. |
sergisiso
reviewed
Jun 21, 2024
src/psyclone/psyir/nodes/schedule.py
Outdated
Comment on lines
99
to
104
| def debug_string(self): | ||
| debug_string = "" | ||
| for statement in self.children: | ||
| debug_string += statement.debug_string() | ||
| return debug_string | ||
|
|
There was a problem hiding this comment.
I don't think we need this (and associated test) now that a "schedule_node" visitor has been introduced to the Writer, do we?
There was a problem hiding this comment.
You're right, I'd forgotten this defaults to DebugWriter and thus to FortranWriter. They're now removed.
…to `FortranWriter`.
JulienRemy
changed the title
Schedule().debug_string() and FortranWriter().schedule_node().FortranWriter().schedule_node().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids defaulting to
str(schedule)forSchedule().debug_string()and raising aVisitorErrorusingFortranWriter()(Schedule()).