Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LFRic] bug when profiling applied within a Loop #2796

Open
arporter opened this issue Nov 21, 2024 · 0 comments
Open

[LFRic] bug when profiling applied within a Loop #2796

arporter opened this issue Nov 21, 2024 · 0 comments
Labels
bug LFRic Issue relates to the LFRic domain Release Planning and creating PSyclone releases

Comments

@arporter
Copy link
Member

Jaffery has found that applying ProfileTrans to nodes within a loop generates incorrect code. The profile_psydatatype is imported correctly but no variable with that type is ever declared. If I alter the script to make sure the profiling is put outside the loop then the associated variable is declared correctly. I suspect this is because we currently handle everything within a loop with PSyIR and everything outside with the old gen_code method.

If it isn't too hard to fix then it would be good to get this done before 3.0 is released.

@arporter arporter added bug LFRic Issue relates to the LFRic domain Release Planning and creating PSyclone releases labels Nov 21, 2024
arporter added a commit that referenced this issue Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug LFRic Issue relates to the LFRic domain Release Planning and creating PSyclone releases
Projects
None yet
Development

No branches or pull requests

1 participant