Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2758 fix compilation tests #2759

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

2758 fix compilation tests #2759

wants to merge 3 commits into from

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Oct 28, 2024

A few small changes to fix #2758.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (33ff7e8) to head (1eb8192).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2759   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         354      354           
  Lines       48967    48967           
=======================================
  Hits        48903    48903           
  Misses         64       64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiker
Copy link
Collaborator Author

hiker commented Oct 28, 2024

Ready for review. The link check failure (to https://fortranwiki.org/fortran/show/Intrinsic+procedures) is not caused by this PR, the site seems unavailable atm.

arporter
arporter requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the quick fix Joerg. All looks good and nice to see how encapsulated the problem was.
However, I've realised that we have lib/extract/{netcdf,standalone}/nemo and the READMEs in those directories talk about the NEMO API. Would you mind renaming those directories (perhaps s/nemo/no_psykal/ or something) and updating the READMEs too?

@hiker hiker mentioned this pull request Oct 31, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arporter arporter arporter requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
reviewed with actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation test failures
2 participants
@hiker @arporter