Fix content removal on css inline cleanup #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Regex `'/(\s)+class="(.*)"(\s)+/U'` will always expect a class attribute to contain an space at the end of the attribute, which is not always the case. - The regex `'/(\s)+class="(.*)"/U'` will match the class attribute even if it is the last attribute of the tag. Repro: https://www.phpliveregex.com/p/KWH With fix: https://www.phpliveregex.com/p/KXi
kenntchan
approved these changes
Feb 5, 2024
kenntchan
approved these changes
Feb 5, 2024
kenntchan
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex
'/(\s)+class="(.*)"(\s)+/U'will always expect a class attribute to contain an spaceat the end of the attribute, which is not always the case.
The regex
'/(\s)+class="(.*)(\s)*"/U'will match the class attribute even if it is the lastattribute of the tag.
Repro: https://www.phpliveregex.com/p/KWH
With fix: https://www.phpliveregex.com/p/KXi