Create interface for retrieving git version information

steveukx · Sep 3, 2022 · 8cd3c83 · 8cd3c83
1 parent 7899462
commit 8cd3c83
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/simple-git/src/lib/tasks/config.ts b/simple-git/src/lib/tasks/config.ts
@@ -1,7 +1,7 @@
-import { ConfigGetResult, ConfigListSummary, SimpleGit } from '../../../typings';
+import type { ConfigGetResult, ConfigListSummary, SimpleGit } from '../../../typings';
 import { configGetParser, configListParser } from '../responses/ConfigList';
-import { SimpleGitApi } from '../simple-git-api';
-import { StringTask } from '../types';
+import type { SimpleGitApi } from '../simple-git-api';
+import type { StringTask } from '../types';
 import { trailingFunctionArgument } from '../utils';
 
 export enum GitConfigScope {

diff --git a/simple-git/typings/simple-git.d.ts b/simple-git/typings/simple-git.d.ts
@@ -170,7 +170,7 @@ export interface SimpleGit extends SimpleGitBase {
       key: string,
       value: string,
       append?: boolean,
-      scope?: keyof types.GitConfigScope,
+      scope?: keyof typeof types.GitConfigScope,
       callback?: types.SimpleGitTaskCallback<string>
    ): Response<string>;
 
@@ -205,7 +205,7 @@ export interface SimpleGit extends SimpleGitBase {
     * Configuration values visible to git in the current working directory
     */
    listConfig(
-      scope: keyof types.GitConfigScope,
+      scope: keyof typeof types.GitConfigScope,
       callback?: types.SimpleGitTaskCallback<resp.ConfigListSummary>
    ): Response<resp.ConfigListSummary>;
 
@@ -557,7 +557,7 @@ export interface SimpleGit extends SimpleGitBase {
     */
    getConfig(
       key: string,
-      scope?: keyof types.GitConfigScope,
+      scope?: keyof typeof types.GitConfigScope,
       callback?: types.SimpleGitTaskCallback<string>
    ): Response<resp.ConfigGetResult>;
 

diff --git a/simple-git/typings/types.d.ts b/simple-git/typings/types.d.ts
@@ -14,7 +14,7 @@ export type { ApplyOptions } from '../src/lib/tasks/apply-patch';
 export type { CheckRepoActions } from '../src/lib/tasks/check-is-repo';
 export type { CleanOptions, CleanMode } from '../src/lib/tasks/clean';
 export type { CloneOptions } from '../src/lib/tasks/clone';
-export type { GitConfigScope } from '../src/lib/tasks/config';
+export { GitConfigScope } from '../src/lib/tasks/config';
 export type { GitGrepQuery, grepQueryBuilder } from '../src/lib/tasks/grep';
 export type { ResetOptions, ResetMode } from '../src/lib/tasks/reset';
 export type { VersionResult } from '../src/lib/tasks/version';