Further simplify StaticArrays usage #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 7 7
Lines 223 223
=======================================
Hits 209 209
Misses 14 14
Continue to review full report at Codecov.
|
stevengj
reviewed
Mar 21, 2018
| # a row vector, which leads to a non-SMatrix.) Therefore, we first calculate M' | ||
| # (which remains SMatrix) and recover M. | ||
| M = (((ndir .* r2)' ./ sqrt.(ndir'.^2 * r2)) * b.p)' | ||
| M = b.p' * ((ndir .* r2) ./ sqrt.(r2' * ndir.^2)) |
There was a problem hiding this comment.
Isn't r2 a real scalar, and hence doesn't need the '? Also use .* to fuse that multiply with the other dot ops.
There was a problem hiding this comment.
No, in this case r2 is a vector of the squared radii of the ellipsoid, and ndir is a matrix, so I think the operations are used correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the efforts in #27, eliminate unnecessary transpose operations on
SVectors after JuliaArrays/StaticArrays.jl#274.