Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ldap config missing argument bug #1064

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix ldap config missing argument bug #1064

merged 2 commits into from
Oct 24, 2024

Conversation

KuroXII
Copy link
Contributor

@KuroXII KuroXII commented Oct 22, 2024 •
edited
Loading

I have fixed the ldap configuration error in latest release.

Error: template: nexus3/templates/job-config.yaml:16:28: executing "nexus3/templates/job-config.yaml" at <include (print $.Template.BasePath "/configmap-config.yaml") .>: error calling include: template: nexus3/templates/configmap-config.yaml:33:9: executing "nexus3/templates/configmap-config.yaml" at <toJson>: wrong number of args for toJson: want 1 got 0

Please review it and release a new helm chart version when you available.
Thanks

stevehipwell
stevehipwell requested changes Oct 24, 2024
View reviewed changes
Copy link
Owner

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this. Could you please add a CHANGELOG entry for your change?

@KuroXII
Copy link
Contributor Author

KuroXII commented Oct 24, 2024

I have add CHANGELOG entry.
Feel free to check for it.

stevehipwell
stevehipwell approved these changes Oct 24, 2024
View reviewed changes
Copy link
Owner

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell merged commit 4016f6e into stevehipwell:main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehipwell stevehipwell stevehipwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KuroXII @stevehipwell @hockleongloh