fix: Fixed incorrect volume claim label pattern (#1067)

Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell · Oct 24, 2024 · 823c4c7 · 823c4c7
1 parent 0000838
commit 823c4c7
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 5 deletions.
diff --git a/charts/confluence-server/CHANGELOG.md b/charts/confluence-server/CHANGELOG.md
@@ -14,6 +14,13 @@
 
 ## [UNRELEASED]
 
+> [!IMPORTANT]
+> If you're using a `StatefulSet` and upgrading to this version you will need to run `kubectl --namespace <namespace> delete statefulset <name> --cascade=orphan` before upgrading as there was a bug in previous versions of this chart that incorrectly labeled the volume claim template.
+
+### Fixed
+
+- Fixed incorrect labeling on the volume claim template. ([#1067](https://github.com/stevehipwell/helm-charts/pull/1067)) _@stevehipwell_
+
 ## [v5.7.1] - 2024-01-16
 
 > [!CAUTION]

diff --git a/charts/confluence-server/templates/statefulset.yaml b/charts/confluence-server/templates/statefulset.yaml
@@ -183,7 +183,7 @@ spec:
     - metadata:
         name: {{ include "confluence-server.pvcname" . }}
         labels:
-          {{- include "confluence-server.labels" . | nindent 10 }}
+          {{- include "confluence-server.selectorLabels" . | nindent 10 }}
         {{- with .Values.persistence.annotations }}
         annotations:
           {{- . | toYaml | nindent 10 }}

diff --git a/charts/nexus3/CHANGELOG.md b/charts/nexus3/CHANGELOG.md
@@ -21,13 +21,13 @@
 
 ### Changed
 
-- Changed the order of the initialization scripts to allow creating roles based on repository privileges. ([#xxxx](https://github.com/stevehipwell/helm-charts/pull/xxxx)) _@stevehipwell_ & _@mreiche_
-- Improved docs for config with reference to the API documentation. ([#xxxx](https://github.com/stevehipwell/helm-charts/pull/xxxx)) _@stevehipwell_ & _@mreiche_
+- Changed the order of the initialization scripts to allow creating roles based on repository privileges. ([#1066](https://github.com/stevehipwell/helm-charts/pull/1066)) _@stevehipwell_ & _@mreiche_
+- Improved docs for config with reference to the API documentation. ([#1066](https://github.com/stevehipwell/helm-charts/pull/1066)) _@stevehipwell_ & _@mreiche_
 
 ### Fixed
 
 - Fixed LDAP templating incorrectly using `toJson` without passing in the data resulting in no configuration to apply. ([#1064](https://github.com/stevehipwell/helm-charts/pull/1064)) _@KuroXII_
-- Fixed incorrect labeling on the volume claim template. ([#xxxx](https://github.com/stevehipwell/helm-charts/pull/xxxx)) _@stevehipwell_
+- Fixed incorrect labeling on the volume claim template. ([#1066](https://github.com/stevehipwell/helm-charts/pull/1066)) _@stevehipwell_
 
 ## [v5.1.0] - 2024-10-14
 

diff --git a/charts/sonarqube/CHANGELOG.md b/charts/sonarqube/CHANGELOG.md
@@ -14,6 +14,13 @@
 
 ## [UNRELEASED]
 
+> [!IMPORTANT]
+> If you're using a `StatefulSet` and upgrading to this version you will need to run `kubectl --namespace <namespace> delete statefulset <name> --cascade=orphan` before upgrading as there was a bug in previous versions of this chart that incorrectly labeled the volume claim template.
+
+### Fixed
+
+- Fixed incorrect labeling on the volume claim template. ([#1067](https://github.com/stevehipwell/helm-charts/pull/1067)) _@stevehipwell_
+
 ## [v5.7.0] - 2024-10-04
 
 ### Changed

diff --git a/charts/sonarqube/templates/statefulset.yaml b/charts/sonarqube/templates/statefulset.yaml
@@ -250,7 +250,7 @@ spec:
     - metadata:
         name: {{ include "sonarqube.pvcname" . }}
         labels:
-          {{- include "sonarqube.labels" . | nindent 10 }}
+          {{- include "sonarqube.selectorLabels" . | nindent 10 }}
         {{- with .Values.persistence.annotations }}
         annotations:
           {{- . | toYaml | nindent 10 }}