feat: add path in ConformInfo #244
Conversation
|
Adding extra options for such niche setting doesn't sound right. How about using conceal? |
stevearc
left a comment
stevearc
left a comment
There was a problem hiding this comment.
Not sure what you mean with your question about formatter.type
I think it's fine to include the binary path all the time. No need for an option. The info panel should only be used for debugging, so it's fine if it's a little visually busy.
Couple changes requested, but generally on board with the approach
lua/conform/init.lua
Outdated
| ---@class (exact) conform.FormatterInfo | ||
| ---@field name string | ||
| ---@field command string | ||
| ---@field path? string |
There was a problem hiding this comment.
We don't really need to add the path here, do we? We can just run exepath from the info window where we need the full path
There was a problem hiding this comment.
Sorry made a mistake, I meant formatter.path instead of type but here you're answering my question.
Yeah, I think we don't. We only use path in the info panel, so it can be produced there.
lua/conform/health.lua
Outdated
| table.insert(highlights, { | ||
| "DiagnosticInfo", | ||
| #lines, | ||
| formatter.name:len() + 7 + table.concat(filetypes, ", "):len() + 3, |
There was a problem hiding this comment.
Let's pull the table.concat(filetypes, ", ") into a variable so we don't have to run it twice
|
@stevearc I just squashed the requested changes into my commit. |
lua/conform/health.lua
Outdated
| highlights, | ||
| { "DiagnosticInfo", #lines, formatter.name:len(), formatter.name:len() + 6 } | ||
| ) | ||
| if path ~= nil then |
There was a problem hiding this comment.
vim.fn.exepath never returns nil. If the executable is missing, it will return an empty string
There was a problem hiding this comment.
Oh right! Thanks for taking the time to review thoroughly
|
Great, thanks for the PR! |
3 participants
Here is my draft for #225
2 questions:
formatter.typebeing astring?set asnilwhen initialized?Any thoughts?