-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/not fail on receiving with unknown ocpp properties #1460
Feature/not fail on receiving with unknown ocpp properties #1460
Conversation
thanks for the contribution. can you pls write a description and motivation for the changes? why are you adding nginx? this PR is mixing two concerns. |
Thanks for your remind! Do you think it is meaningful for others? I can update related README adding a line of explanation or the nginx URL if the comunity need it. |
hey there, thanks for the updates and motivation. i find both of these optional, but i like one better than the other.
|
Got it.
Understood. I will make it configureable in the main.properties and recreate the PR. Closing this PR. |
i am actually fine with the current state of custom msg fields. no need for additional configuration. i just would like to omit the nginx changes. |
@goekay |
we are trying to use SteVe to provide customer the OCPP Server, facing these problems and solving it.
=>So I made it not to fail on receiving with unknown ocpp properties
=>So I added a reverse proxy to handle this locally first.
=>Not related to the title of the Pull Request so it is REVERSED.