Fix issue related to invalid characters in tags being submitted. #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour of SteVe is to create a new OCPP tag if the charging point submits an unknown tag. If this tag contains invalid characters, the entry ends up in an invalid state: - you cannot see it in the OCPP tag overview page (and also isn't displayed in the unknown tag section) - if you go to the active/past sessions pane, and click through to the tag over there, you cannot edit or delete the tag since it doesn't pass validation. This bug gets triggered because some charge points send arbitrary text as a tag when FreeCharge mode is enabled. The Webasto Next [1] chargepoint I use triggers this bug, since it uses the #FreeCharging tag ID when freecharging is enabled. This PR adds the '#' sign to the whitelist of characters allowed, fixing this issue. [1]: https://charging.webasto.com/int/products/webasto-next/
|
thank you @friedkiwi ! |
|
@friedkiwi could you pls add a test case in IdTagValidatorTest that addresses this exact use case? |
Done. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of SteVe is to create a new OCPP tag if the charging point submits an unknown tag. If this tag contains invalid characters, the entry ends up in an invalid state:
This bug gets triggered because some charge points send arbitrary text as a tag when FreeCharge mode is enabled. The Webasto Next (https://charging.webasto.com/int/products/webasto-next/) chargepoint I use triggers this bug, since it uses the #FreeCharging tag ID when freecharging is enabled.
This PR adds the '#' sign to the whitelist of characters allowed, fixing this issue.