Use the default values for input/output buffers #846 #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was using a buffer of 8Mb. This meant that for every message received/sent, a buffer of 8Mb was being allocated. This in turn were causing a log of memory pressure and the service would crash with Out of Memory. After this change, the IO buffers have a 4Kb size that doesn't create the same memory pressure. Even if the buffer is only 4Kb, it still works for messages that are bigger than 4Kb.
|
thanks @jpires |
|
@rdc-Green You should be able to add this changes to your local copy. |
|
@rdc-Green the newest release is 3.5.0 and it does not contain the api functionality yet. i did not make a release including the api yet. |
|
Hi @goekay it does have api settings in the main.properties file though and our api has stopped working. We have resolved our issue however so there is no issue. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the excessive memory usage when a new websocket message is received.
For more details, check the issue #846.