Extract tag authorization in a dedicated service #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juherr
force-pushed
the
feature/external-authorization
branch
2 times, most recently
from
5922f72
to
c9333e0
Compare
|
late feedback: i think the goal is valuable. couple of suggestion from my side:
|
juherr
force-pushed
the
feature/external-authorization
branch
from
c9333e0
to
f04d6f1
Compare
|
@goekay done as suggested |
goekay
requested changes
Jul 14, 2024
src/main/java/de/rwth/idsg/steve/utils/OcppTagActivityRecordUtils.java
Outdated
Show resolved
Hide resolved
|
@juherr are you willing to do the changes or should i do them after merging? |
|
@goekay I'm currently in holidays and without a computer for the next 2 weeks. You can wait or make the changed. |
goekay
approved these changes
Jul 20, 2024
reason: allow multiple implementations of the same interface to exist. therefore, another impl (for calling external EMSP service) and bean can exist with @primary annotation which can take precedence
|
thanks @juherr ! |
|
@goekay thanks for the merge. Please review the other pull requests if you find some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of the change is to be able to delegate the authorization responsibility to an outside EMSP service if wanted.
WDYT?