Closed
Conversation
KDKHD
reviewed
Jun 24, 2025
| }; | ||
|
|
||
| export const getAllPromptIds = (pGroups: PromptGroup[]) => { | ||
| return pGroups.map((promptGroup: PromptGroup) => [...Object.values(promptGroup)]).flat(); |
KDKHD
reviewed
Jun 24, 2025
| capabilities.actions?.delete === true && | ||
| capabilities.actions?.save === true; | ||
|
|
||
| const starterPromptsEnabled = useIsExperimentalFeatureEnabled('starterPromptsEnabled'); |
There was a problem hiding this comment.
Is this feature flag still enabled through xpack.securitySolution.enableExperimental or is this the new feature flag service?
KDKHD
reviewed
Jun 24, 2025
|
|
||
| const starterPromptsEnabled = useIsExperimentalFeatureEnabled('starterPromptsEnabled'); | ||
| // remove once product has signed off on prompt text | ||
| const isStarterPromptsEnabled = starterPromptsEnabled; |
KDKHD
reviewed
Jun 24, 2025
|
|
||
| const result = await tool.func({ query: 'What is Kibana Security?', product: 'kibana' }); | ||
|
|
||
| expect(result).toContain('The "AI Assistant knowledge base" needs to be installed'); |
KDKHD
reviewed
Jun 24, 2025
| const isKnowledgeBaseInstalled = await getIsKnowledgeBaseInstalled(kbDataClient); | ||
| if (!isKnowledgeBaseInstalled) { | ||
| // prompt to help user install knowledge base | ||
| return 'The "AI Assistant knowledge base" needs to be installed, containing the Security Labs content. Navigate to the Knowledge Base page in the AI Assistant Settings to install it.'; |
There was a problem hiding this comment.
Suggested change
| return 'The "AI Assistant knowledge base" needs to be installed, containing the Security Labs content. Navigate to the Knowledge Base page in the AI Assistant Settings to install it.'; | |
| return 'The "AI Assistant knowledge base" needs to be installed, this will install the Security Labs content. Navigate to the Knowledge Base page in the AI Assistant Settings to install it.'; |
KDKHD
reviewed
Jun 24, 2025
KDKHD
left a comment
KDKHD
left a comment
There was a problem hiding this comment.
Code changes look good - How do I test the starter prompts?
…ed (elastic#221732) ## Summary Resolves: elastic#216810 This PR uses the licensing plugin to check is security is enabled. If not, we skip adding API keys to tasks that pass in a `request` object, but still scheduling them. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temp PR against
context_promptsin order to see the actual diff