feat: add durable message retrieval-reference adapter - #489
Closed
100yenadmin wants to merge 3 commits into
Closed
100yenadmin wants to merge 3 commits into
100yenadmin wants to merge 3 commits into
Conversation
This was referenced Aug 3, 2026
Open
Contributor
Author
|
Closing in favour of #505, the maintenance roll-up — this is commit 3 of that stack. Nothing is dropped — the commits are carried across unchanged, so the review history here stays meaningful and the work is not rewritten. The consolidation is packaging: a system-level change reads better as one ordered stack than as several PRs that have to be merged in the right sequence to make sense. Apologies for the churn on your queue. |
9 of 12 tasks
This was referenced Aug 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messageretrieval-reference adapter over the V1 authority foundation in feat: add provenance-bound retrieval reference foundation #487;messages.store_id, caller-supplied authorization scope, and a SHA-256 semantic revision;tool_calls, and finite timestamps before hashing;pinnedandtoken_estimatefields from semantic staleness;BEGIN IMMEDIATEor a caller-owned transaction;MessageStore's re-entrant write lock so shared-connection writers cannot interleave; raw SQLite callers retain caller-managed concurrency;Why
#487 establishes a product-neutral opaque authority but intentionally does not load target rows. Before strong mutation-safe pagination (#477) can reuse that authority, one target adapter must prove exact target/revision binding, authorization-before-disclosure, transactional rollback, and mutation behavior end to end.
This PR is that single vertical. It does not change
tools.py, public schemas, or numeric schema version 5.Verification
Sandboxed root matrix with both
HERMES_HOMEandLCM_DATABASE_PATHisolated:Result: 147 passed (including packaging/install coverage).
Focused adapter suite: 30 passed, including:
All clean.
Stack and scope
bf44dc81982ff507ce86a8f46fb96077a6394b5f), which is stacked on fix: serialize concurrent FTS bootstrap repair #486.Refs #476.