-
Notifications
You must be signed in to change notification settings - Fork 163
feat: expose compression no-op status #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stephenschoettler
merged 4 commits into
stephenschoettler:main
from
TurgutKural:fix/public-compression-noop-status
Jul 5, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c82d228
feat: expose compression no-op status
TurgutKural 5fb3d9e
Merge branch 'main' into fix/public-compression-noop-status
stephenschoettler caf1f9e
fix: clear stale compression noop status on preflight
stephenschoettler 16988d6
Merge branch 'main' into fix/public-compression-noop-status
stephenschoettler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a session first hits a preflight no-op (for example, only the fresh tail is over threshold) and a later call to
should_compress_preflight(...)becomes eligible, this property still reportsTruebecause the positive preflight paths return without clearing_last_compression_statusor the no-op reason. A host using the new public flag immediately after preflight can therefore misclassify the next real compaction boundary as an LCM no-op untilcompress()starts. Please clear or update the status/reason on positive preflight decisions before exposing this flag.Useful? React with 👍 / 👎.