Django 4.0.0 compatibility #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change deprecated and removed methods in Django 4.0 * `url` => `re_path` * `smart_text` => `smart_str` * `is_safe_url` => `url_has_allowed_host_and_scheme` * `force_text` => `force_str` * `ungettext` => `ngettext` * `urlquote` => quote (urllib.parse) Fix Signals init Add `pytz` to requirements. Should migrate from `pytz` to `zoneinfo` at some point
tswfi
commented
Dec 21, 2021
| @@ -48,7 +48,8 @@ install_requires = | |||
| requests-oauthlib >= 1.3 | |||
| pillow >= 7 | |||
| chardet >= 4 | |||
| filebrowser_safe@https://github.com/stephenmcd/filebrowser-safe/archive/master.tar.gz | |||
| pytz | |||
| filebrowser_safe@https://github.com/tswfi/filebrowser-safe/archive/refs/heads/django_4.0.0_compatibility.zip | |||
There was a problem hiding this comment.
TODO: this must be changed back before merging
`get_middleware_request` for middlewares `request_is_ajax` to replace `request.is_ajax()`'
|
mezzanine/.github/workflows/main.yml Line 91 in a2fa5c8 on push / pr and another "deploy" workflow be implemented for just the master branch?
|
Closed
1 task
Closed
1 task
|
Great work @tswfi! |
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change deprecated and removed methods in Django 4.0
url=>re_pathsmart_text=>smart_stris_safe_url=>url_has_allowed_host_and_schemeforce_text=>force_strungettext=>ngettexturlquote=> quote (urllib.parse)Fix Signals init
Add
pytzto requirements. Should migrate frompytztozoneinfoat some pointStill a WIP. There are few tests that fail with 4.0 but I want to see what happens with the CI and if there are other things that might require attention.Also gets the filebrowser_safe from my branch that is already 4.0 compatible TODO: this must be switched back as soon as upstream has merged my patch. Also should probably get the package from pypi not from the master branch in git.
Fixes: #2008 and #2007