Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented add batching #202

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Implemented add batching #202

merged 3 commits into from
Oct 21, 2021

Conversation

cloewen8
Copy link
Contributor

@cloewen8 cloewen8 commented Oct 21, 2021

Allows git add to be called in multiple passes based on how many files are queued. This should be a non-breaking change.

  • Added a maxFiles option to add; Which limits how many files can be added at a time (defaults to Infinity).
  • Removed through2 from add.js.
  • Documented maxFiles and added a solution in "Possible errors".

I originally intended to use a Duplex with writev, but found that it didn't properly emit 'end'. After further consideration, I realized that by using Transform, the stream would look identical outward, reducing the chances of incompatibility.

fixes #201

Removed dependence on through2 and created a maxFiles option for batch adding files (defaults to no batching).
@cloewen8 cloewen8 changed the title Implemented add batching (fixes #201) Implemented add batching (fixes #201 ) Oct 21, 2021
@cloewen8 cloewen8 changed the title Implemented add batching (fixes #201 ) Implemented add batching Oct 21, 2021
cloewen8 added a commit to cloewen8/gulp-git that referenced this pull request Oct 21, 2021
@stephenlacy stephenlacy merged commit d906811 into stephenlacy:master Oct 21, 2021
@cloewen8 cloewen8 mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"The command line is too long." on git.add()
2 participants