Increase coverage target#4
Merged
stephen-crawford merged 2 commits intostephen-crawford:boostedCoveragefrom Aug 22, 2023
Merged
Increase coverage target#4stephen-crawford merged 2 commits intostephen-crawford:boostedCoveragefrom
stephen-crawford merged 2 commits intostephen-crawford:boostedCoveragefrom
Conversation
In RestLayerPrivilegesEvaluator there was a number of unused parameters removed those to trim down the test requirements. For the test cases switched to assertThat for easy of reading, enabled debug logging to exercise debug logging code, adjusted usages of mocks for cleaner test flow in a couple of spaces. Verified locally with the following command and then checked the jacoco report under build/reports/jacoco/test/html/... ./gradlew jacocoTestReport test --tests \ org.opensearch.security.privileges.RestLayerPrivilegesEvaluatorTest Signed-off-by: Peter Nied <petern@amazon.com>
…erage Signed-off-by: Peter Nied <petern@amazon.com>
peternied
force-pushed
the
boostedCoverage
branch
from
522de7c to
b1ac98b
Compare
3 tasks
Collaborator
Author
|
From my local report |
peternied
commented
Aug 22, 2023
| } | ||
|
|
||
| @Test | ||
| public void testIsInitialized_False() { |
Collaborator
Author
There was a problem hiding this comment.
Rearranged to testEvaluate_NotInitialized_NullModel_ExceptionThrown method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In RestLayerPrivilegesEvaluator there was a number of unused parameters removed those to trim down the test requirements.
For the test cases switched to assertThat for easy of reading, enabled debug logging to exercise debug logging code, adjusted usages of mocks for cleaner test flow in a couple of spaces.
Verified locally with the following command and then checked the jacoco report under build/reports/jacoco/test/html/...
Signed-off-by: Peter Nied petern@amazon.com