-
-
Notifications
You must be signed in to change notification settings - Fork 1
perf(multipublish): update lint paths to use root #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
fc9adfd
c0c1ba4
c56fa9a
c2e519d
22bd289
45c1f9d
a5a7e6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@stephansama/eslint-config": patch | ||
| "@stephansama/multipublish": patch | ||
| --- | ||
|
|
||
| updated eslint node modules options |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,8 @@ | ||||||
| # Auto Readme 🪄 | ||||||
| <div align="center"> | ||||||
|
|
||||||
| # [`@stephansama`](https://github.com/stephansama) / \[`auto-readme`]\(https://packages.stephansama.info/api/@stephansama/auto-readme/) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix malformed markdown link syntax. The escaped brackets ( 🔗 Proposed fix-# [`@stephansama`](https://github.com/stephansama) / \[`auto-readme`]\(https://packages.stephansama.info/api/@stephansama/auto-readme/)
+# [`@stephansama`](https://github.com/stephansama) / [`auto-readme`](https://packages.stephansama.info/api/@stephansama/auto-readme/)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| </div> | ||||||
|
|
||||||
| [](https://github.com/stephansama/packages/tree/main/core/auto-readme) | ||||||
| [](https://packages.stephansama.info/api/@stephansama/auto-readme) | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| # [Catppuccin](https://github.com/catppuccin/catppuccin) x [Pretty-feed-v3](https://github.com/genmon/aboutfeeds/blob/main/tools/pretty-feed-v3.xsl) | ||
| <div align="center"> | ||
|
|
||
| # [`@stephansama`](https://github.com/stephansama) / \[`catppuccin-rss`]\(https://packages.stephansama.info/api/@stephansama/catppuccin-rss/) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix malformed markdown link syntax. The escaped brackets ( 🔗 Proposed fix-# [`@stephansama`](https://github.com/stephansama) / \[`catppuccin-rss`]\(https://packages.stephansama.info/api/@stephansama/catppuccin-rss/)
+# [`@stephansama`](https://github.com/stephansama) / [`catppuccin-rss`](https://packages.stephansama.info/api/@stephansama/catppuccin-rss/)🤖 Prompt for AI Agents |
||
|
|
||
| </div> | ||
|
|
||
| [](https://github.com/stephansama/packages/tree/main/core/catppuccin-rss) | ||
| [](https://packages.stephansama.info/api/@stephansama/catppuccin-rss) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,15 +23,15 @@ export function config(options: Options): Config[] { | |
| "n/no-extraneous-import": [ | ||
| "error", | ||
| { | ||
| allowModules: options.allowModules || [], | ||
| resolvePaths: options.resolvePaths || [], | ||
| allowModules: options?.allowModules || [], | ||
| resolvePaths: options?.resolvePaths || [], | ||
|
Comment on lines
+26
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The use of optional chaining ( |
||
| }, | ||
| ], | ||
| "n/no-extraneous-require": [ | ||
| "error", | ||
| { | ||
| allowModules: options.allowModules || [], | ||
| resolvePaths: options.resolvePaths || [], | ||
| allowModules: options?.allowModules || [], | ||
| resolvePaths: options?.resolvePaths || [], | ||
| }, | ||
| ], | ||
| // handled by ./imports.ts | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,8 @@ | ||||||
| # create-stephansama-example | ||||||
| <div align="center"> | ||||||
|
|
||||||
| # [`@stephansama`](https://github.com/stephansama) / \[`# create-stephansama-example`]\(https://packages.stephansama.info/api/@stephansama/# create-stephansama-example/) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix malformed markdown link syntax. The escaped brackets ( 🔗 Proposed fix-# [`@stephansama`](https://github.com/stephansama) / \[`# create-stephansama-example`]\(https://packages.stephansama.info/api/@stephansama/# create-stephansama-example/)
+# [`@stephansama`](https://github.com/stephansama) / [`create-stephansama-example`](https://packages.stephansama.info/api/create-stephansama-example/)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| </div> | ||||||
|
|
||||||
| [](https://github.com/stephansama/packages/tree/main/core/example) | ||||||
| [](https://packages.stephansama.info/api/create-stephansama-example) | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| const cli = await import("./dist/index.js"); | ||
| const cli = await import("./dist/index.mjs"); | ||
| await cli.run(); |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -37,8 +37,8 @@ | |||||||||
| "scripts": { | ||||||||||
| "build": "node build.mjs", | ||||||||||
| "dev": "node --watch build.mjs", | ||||||||||
| "lint": "eslint ./src/ --pass-on-no-patterns --no-error-on-unmatched-pattern", | ||||||||||
| "lint:fix": "eslint ./src/ --pass-on-no-patterns --no-error-on-unmatched-pattern --fix" | ||||||||||
| "lint": "eslint ./ --pass-on-no-patterns --no-error-on-unmatched-pattern", | ||||||||||
| "lint:fix": "eslint ./ --pass-on-no-patterns --no-error-on-unmatched-pattern --fix" | ||||||||||
|
Comment on lines
+40
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changing the lint target from
Suggested change
|
||||||||||
| }, | ||||||||||
| "dependencies": { | ||||||||||
| "@manypkg/find-root": "catalog:", | ||||||||||
|
|
||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,8 @@ | ||||||||||||||||||||||||||
| # @stephansama/single-file | ||||||||||||||||||||||||||
| <div align="center"> | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # [`@stephansama`](https://github.com/stephansama) / [`single-file`](https://packages.stephansama.info/api/@stephansama/single-file/) | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||
|
Comment on lines
+1
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a top-level Markdown heading on the first line to satisfy MD041.
Proposed fix+ # `@stephansama/single-file`
+
<div align="center">
# [`@stephansama`](https://github.com/stephansama) / [`single-file`](https://packages.stephansama.info/api/@stephansama/single-file/)
</div>📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.22.1)[warning] 1-1: First line in a file should be a top-level heading (MD041, first-line-heading, first-line-h1) 🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| [](https://github.com/stephansama/packages/tree/main/core/single-file) | ||||||||||||||||||||||||||
| [](https://packages.stephansama.info/api/@stephansama/single-file) | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,8 @@ | ||||||
| # svelte-social-share-links | ||||||
| <div align="center"> | ||||||
|
|
||||||
| # [`@stephansama`](https://github.com/stephansama) / \[`svelte-social-share-links`]\(https://packages.stephansama.info/api/@stephansama/svelte-social-share-links/) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix escaped brackets in package link. The markdown link for the package name contains escaped brackets 🐛 Proposed fix-# [`@stephansama`](https://github.com/stephansama) / \[`svelte-social-share-links`]\(https://packages.stephansama.info/api/@stephansama/svelte-social-share-links/)
+# [`@stephansama`](https://github.com/stephansama) / [`svelte-social-share-links`](https://packages.stephansama.info/api/@stephansama/svelte-social-share-links/)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| </div> | ||||||
|
|
||||||
| [](https://github.com/stephansama/packages/tree/main/core/svelte-social-share-links) | ||||||
| [](https://packages.stephansama.info/api/@stephansama/svelte-social-share-links) | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,6 +2,15 @@ import { defineConfig } from "monoman"; | |||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| type PackageJsonLike = Record<string, Record<string, string> | string>; | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| const oldStephansamaHeader = /# @stephansama\//; | ||||||||||||||||||||||||||||||||
| const newStephansamaHeader = ` | ||||||||||||||||||||||||||||||||
| <div align="center"> | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| # [\`@stephansama\`](https://github.com/stephansama) / [\`{{package}}\`](https://packages.stephansama.info/api/@stephansama/{{package}}/) | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||
| `.trim(); | ||||||||||||||||||||||||||||||||
|
Comment on lines
+6
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Template triggers MD041 ( All generated READMEs start with ✏️ Proposed fix: inline markdownlint disable in the template const newStephansamaHeader = `
+<!-- markdownlint-disable-next-line MD041 -->
<div align="center">📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| export default defineConfig([ | ||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||
| contents(data: PackageJsonLike) { | ||||||||||||||||||||||||||||||||
|
|
@@ -13,4 +22,20 @@ export default defineConfig([ | |||||||||||||||||||||||||||||||
| include: ["**/package.json"], | ||||||||||||||||||||||||||||||||
| type: "json", | ||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||
| contents(text) { | ||||||||||||||||||||||||||||||||
| if (!text) return ""; | ||||||||||||||||||||||||||||||||
| return text | ||||||||||||||||||||||||||||||||
| .replace(oldStephansamaHeader, "") | ||||||||||||||||||||||||||||||||
| .split("\n") | ||||||||||||||||||||||||||||||||
| .map((_, index) => { | ||||||||||||||||||||||||||||||||
| if (index > 0) return _; | ||||||||||||||||||||||||||||||||
| return newStephansamaHeader.replaceAll("{{package}}", _); | ||||||||||||||||||||||||||||||||
| }) | ||||||||||||||||||||||||||||||||
| .join("\n"); | ||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||
| exclude: ["README.md", "examples/**/README.md"], | ||||||||||||||||||||||||||||||||
| include: ["**/README.md"], | ||||||||||||||||||||||||||||||||
| type: "text", | ||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||
|
Comment on lines
+25
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-idempotent transformation will corrupt READMEs on every subsequent After the first run, each README starts with 🐛 Proposed fix: guard with an early-return when the old header is absent contents(text) {
if (!text) return "";
+ if (!oldStephansamaHeader.test(text)) return text;
return text
.replace(oldStephansamaHeader, "")
.split("\n")🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||
| ]); | ||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,8 @@ __versions: | |
| autoInstallPeers: true | ||
|
|
||
| catalog: | ||
| '@ai-sdk/google': ^3.0.29 | ||
| '@ai-sdk/openai': ^3.0.29 | ||
| '@antfu/install-pkg': 1.1.0 | ||
| '@bluwy/giget-core': 0.1.6 | ||
| '@catppuccin/palette': 1.7.1 | ||
|
|
@@ -39,6 +41,7 @@ catalog: | |
| '@types/vfile': 4.0.0 | ||
| '@types/yargs': 17.0.35 | ||
| actions-up: 1.11.0 | ||
| ai: ^6.0.86 | ||
| alfy: 2.1.0 | ||
| astro: 5.9.3 | ||
| cheerio: 1.2.0 | ||
|
|
@@ -58,11 +61,15 @@ catalog: | |
| mdast: 3.0.0 | ||
| mdast-comment-marker: ^3.0.0 | ||
| mdast-util-from-markdown: ^2.0.2 | ||
| mdast-zone: github:stephansama/mdast-zone#1c5b08cd97240debeed4c9c6afad49df5877a132 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial | 💤 Low value
Consider publishing the fork to npm/JSR and updating the reference, or at minimum opening a tracking issue. Would you like me to open a tracking issue to publish 🤖 Prompt for AI Agents |
||
| minify: 14.0.0 | ||
| monoman: 0.8.2 | ||
| nano-staged: 1.0.2 | ||
| neverthrow: ^8.2.0 | ||
| node-plop: 0.32.3 | ||
| ollama-ai-provider-v2: ^1.5.5 | ||
| oxc-parser: 0.127.0 | ||
| package-manager-detector: ^1.6.0 | ||
| pkg-pr-new: 0.0.51 | ||
| pkg-types: ^2.3.0 | ||
| publint: 0.3.17 | ||
|
|
@@ -188,6 +195,12 @@ catalogs: | |
| '@vitest/coverage-v8': 4.0.18 | ||
| '@vitest/ui': 4.0.18 | ||
| vitest: 4.0.18 | ||
| conflicts_dedent_h1_7_1: | ||
| dedent: ^1.7.1 | ||
| conflicts_commitlint_h19_8_1: | ||
| '@commitlint/config-conventional': ^19.8.1 | ||
| conflicts_@dotenvx/dotenvx_h1_52_0: | ||
| '@dotenvx/dotenvx': ^1.52.0 | ||
|
Comment on lines
+198
to
+203
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Check for any package.json using the conflicts_* catalog references.
# Expected: No matches if the catalog entries are currently unused.
rg -rn --type=json 'catalog:conflicts_' --include='package.json'Repository: stephansama/packages Length of output: 506 🏁 Script executed: #!/bin/bash
# Find all package.json files and search for catalog:conflicts_ references
find . -name 'package.json' -type f | head -20Repository: stephansama/packages Length of output: 786 🏁 Script executed: #!/bin/bash
# Search for catalog:conflicts_ in package.json files with correct rg syntax
rg 'catalog:conflicts_' -g '*.json'Repository: stephansama/packages Length of output: 46 🏁 Script executed: #!/bin/bash
# Check the pnpm-workspace.yaml file to verify the context around line 205
cat -n pnpm-workspace.yaml | sed -n '195,210p'Repository: stephansama/packages Length of output: 547 🏁 Script executed: #!/bin/bash
# Check which packages use dedent directly
rg '"dedent"' -g '*.json' | grep -E 'package.json'Repository: stephansama/packages Length of output: 175 🏁 Script executed: #!/bin/bash
# Check which packages use `@commitlint/config-conventional`
rg '@commitlint/config-conventional' -g '*.json' | grep -E 'package.json'Repository: stephansama/packages Length of output: 220 🏁 Script executed: #!/bin/bash
# Check which packages use `@dotenvx/dotenvx`
rg '@dotenvx/dotenvx' -g '*.json' | grep -E 'package.json'Repository: stephansama/packages Length of output: 259 🏁 Script executed: #!/bin/bash
# Show full dedent context in core/single-file
cat -n core/single-file/package.json | grep -A2 -B2 'dedent'Repository: stephansama/packages Length of output: 216 🏁 Script executed: #!/bin/bash
# Show full dedent context in core/multipublish
cat -n core/multipublish/package.json | grep -A2 -B2 'dedent'Repository: stephansama/packages Length of output: 267 🏁 Script executed: #!/bin/bash
# Show full `@dotenvx/dotenvx` context in core/typed-env
cat -n core/typed-env/package.json | grep -A2 -B2 '@dotenvx/dotenvx'Repository: stephansama/packages Length of output: 348 🏁 Script executed: #!/bin/bash
# Show all catalog entries in pnpm-workspace.yaml to see what's in the default catalog
cat -n pnpm-workspace.yaml | sed -n '1,210p'Repository: stephansama/packages Length of output: 6678
The three conflict catalog entries (lines 198–203) are not referenced anywhere in the workspace. Verification confirms no Either update consuming 🤖 Prompt for AI Agents |
||
|
|
||
| cleanupUnusedCatalogs: true | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| # [@stephansama](https://github.com/stephansama/) package scripts | ||
| <div align="center"> | ||
|
|
||
| # [`@stephansama`](https://github.com/stephansama) / scripts | ||
|
|
||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix malformed markdown syntax in header link.
The package name link has multiple syntax errors:
\[and\(should not be escaped in markdown#  Alfred Kaomoji Pickerinstead of justalfred-kaomoji🐛 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents