-
-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/add socket #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add socket #253
Changes from all commits
3cb134f
15c8cde
65acd10
01f8db9
204c4aa
b34088a
6022b1d
241663d
5691db7
4fd5c9b
3c3d55a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| "@stephansama/catppuccin-jsonresume-theme": patch | ||
| "@stephansama/prettier-plugin-handlebars": patch | ||
| "@stephansama/svelte-social-share-links": patch | ||
| "@stephansama/types-github-action-env": patch | ||
| "@stephansama/find-makefile-targets": patch | ||
| "@stephansama/astro-iconify-svgmap": patch | ||
| "@stephansama/catppuccin-typedoc": patch | ||
| "@stephansama/remark-asciinema": patch | ||
| "@stephansama/typed-nocodb-api": patch | ||
| "@stephansama/catppuccin-opml": patch | ||
| "@stephansama/typed-templates": patch | ||
| "@stephansama/alfred-kaomoji": patch | ||
| "@stephansama/catppuccin-rss": patch | ||
| "@stephansama/catppuccin-xsl": patch | ||
| "@stephansama/ai-commit-msg": patch | ||
| "@stephansama/multipublish": patch | ||
| "@stephansama/typed-events": patch | ||
| "@stephansama/auto-readme": patch | ||
| "@stephansama/github-env": patch | ||
| "@stephansama/types-lhci": patch | ||
| "@stephansama/typed-env": patch | ||
| "create-stephansama-example": patch | ||
| --- | ||
|
|
||
| added socket and jsr badge to relevant packages |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,59 +1,62 @@ | ||
| { | ||
| "ignoreWords": [ | ||
| "COMMIT_EDITMSG", | ||
| "alfy", | ||
| "arktype", | ||
| "asciinema", | ||
| "astrojs", | ||
| "attw", | ||
| "automagically", | ||
| "autoreadme", | ||
| "autoreadmerc", | ||
| "barhandle", | ||
| "barhandles", | ||
| "bluwy", | ||
| "catppuccin", | ||
| "dotenvx", | ||
| "esbuild", | ||
| "feedsmith", | ||
| "giget", | ||
| "headful", | ||
| "healthcheck", | ||
| "iarna", | ||
| "iconify", | ||
| "isbot", | ||
| "kaomoji", | ||
| "kaomojis", | ||
| "lhci", | ||
| "lighthouseci", | ||
| "macchiato", | ||
| "manypkg", | ||
| "multipublish", | ||
| "nocodb", | ||
| "nodemon", | ||
| "nvim", | ||
| "nvmrc", | ||
| "obug", | ||
| "ollama", | ||
| "pkgs", | ||
| "pnpx", | ||
| "pomodoro", | ||
| "randle", | ||
| "rollup", | ||
| "stackblitz", | ||
| "stephan", | ||
| "stephanrandle", | ||
| "stephansama", | ||
| "sveltejs", | ||
| "svgmap", | ||
| "svgmaps", | ||
| "tsdown", | ||
| "typedoc", | ||
| "vite", | ||
| "vitepress", | ||
| "vitest", | ||
| "workerd", | ||
| "yarg" | ||
| ], | ||
| "ignorePaths": [".env"] | ||
| "ignoreWords": [ | ||
| "COMMIT_EDITMSG", | ||
| "alfy", | ||
| "arktype", | ||
| "asciinema", | ||
| "astrojs", | ||
| "attw", | ||
| "automagically", | ||
| "autoreadme", | ||
| "autoreadmerc", | ||
| "barhandle", | ||
| "barhandles", | ||
| "bluwy", | ||
| "catppuccin", | ||
| "commitlint", | ||
| "dotenvx", | ||
| "esbuild", | ||
| "feedsmith", | ||
| "giget", | ||
| "headful", | ||
| "healthcheck", | ||
| "iarna", | ||
| "iconify", | ||
| "isbot", | ||
| "kaomoji", | ||
| "kaomojis", | ||
| "lhci", | ||
| "lighthouseci", | ||
| "macchiato", | ||
| "manypkg", | ||
| "multipublish", | ||
| "nocodb", | ||
| "nodemon", | ||
| "nvim", | ||
| "nvmrc", | ||
| "obug", | ||
| "ollama", | ||
| "packagejson", | ||
| "pkgs", | ||
| "pnpx", | ||
| "pomodoro", | ||
| "randle", | ||
| "rollup", | ||
| "stackblitz", | ||
| "stephan", | ||
| "stephanrandle", | ||
| "stephansama", | ||
| "sveltejs", | ||
| "svgmap", | ||
| "svgmaps", | ||
| "taze", | ||
| "tsdown", | ||
| "typedoc", | ||
| "vite", | ||
| "vitepress", | ||
| "vitest", | ||
| "workerd", | ||
| "yarg" | ||
| ], | ||
| "ignorePaths": [".env"] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| #!/bin/sh | ||
|
|
||
| pnpm dlx commitlint --config .config/.commitlintrc.ts --edit $1 | ||
| pnpm dlx commitlint --config .config/.commitlintrc.ts --edit "$1" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #!/bin/sh | ||
|
|
||
| auto-readme -vg | ||
| auto-readme -g | ||
| lint-staged -v | ||
| pnpm --workspace-root run scripts:lint-examples |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,15 @@ export async function run() { | |
|
|
||
| for (const pkg of releasedPackages) { | ||
| if (args.versionJsr) { | ||
| if (!pkg.packageJson.name.includes("/")) { | ||
| console.warn( | ||
| `attempting to publish a non scoped package skipping`, | ||
| ); | ||
| continue; | ||
| } | ||
|
Comment on lines
+32
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
python - <<'PY'
import json, re
from pathlib import Path
skip_dirs = {".git", "node_modules", "dist", "build", ".next", ".turbo"}
def should_skip(path: Path):
return any(part in skip_dirs for part in path.parts)
def extract_name(path: Path):
txt = path.read_text(encoding="utf-8", errors="ignore")
m = re.search(r'"name"\s*:\s*"([^"]+)"', txt)
return m.group(1) if m else None
for pkg_json in Path(".").rglob("package.json"):
if should_skip(pkg_json):
continue
try:
pkg = json.loads(pkg_json.read_text(encoding="utf-8"))
except Exception:
continue
npm_name = pkg.get("name")
if not isinstance(npm_name, str) or "/" in npm_name:
continue
pdir = pkg_json.parent
for cfg_name in ("jsr.json", "deno.json", "jsr.jsonc", "deno.jsonc"):
cfg = pdir / cfg_name
if not cfg.exists():
continue
jsr_name = extract_name(cfg)
if jsr_name and "/" in jsr_name:
print(f"{pdir}\tnpm={npm_name}\tjsr={jsr_name}\tconfig={cfg_name}")
PYRepository: stephansama/packages Length of output: 46 🏁 Script executed: # First, let's examine the index.ts file around lines 32-37
cat -n core/multipublish/src/index.ts | head -50Repository: stephansama/packages Length of output: 1655 🏁 Script executed: # Also examine the jsr.ts file to understand JSR config loading and validation
cat -n core/multipublish/src/jsr.tsRepository: stephansama/packages Length of output: 3811 🏁 Script executed: # Check if there are any JSR/deno config files in the repo
find . -type f \( -name "jsr.json" -o -name "deno.json" -o -name "jsr.jsonc" -o -name "deno.jsonc" \) ! -path "*/node_modules/*" ! -path "*/.git/*" | head -20Repository: stephansama/packages Length of output: 46 Guard checks npm package name scope instead of JSR config presence or JSR name scope. Line 32 validates Suggested fix-import { updateJsrConfigVersion } from "./jsr";
+import { loadConfig as loadJsrConfig, updateJsrConfigVersion } from "./jsr";
for (const pkg of releasedPackages) {
if (args.versionJsr) {
- if (!pkg.packageJson.name.includes("/")) {
+ const { config: jsrConfig } = await loadJsrConfig(pkg.dir);
+ if (!jsrConfig?.name.includes("/")) {
console.warn(
- `attempting to publish a non scoped package skipping`,
+ `skipping JSR version update for package "${pkg.packageJson.name}" because JSR name is not scoped`,
);
continue;
}
await updateJsrConfigVersion(pkg);🤖 Prompt for AI Agents |
||
|
|
||
| await updateJsrConfigVersion(pkg); | ||
|
|
||
| continue; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Inconsistent badge ordering across READMEs.
The badge order here is JSR → socket.dev, but in
core/catppuccin-xsl/README.mdit's socket.dev → JSR. Consider maintaining a consistent badge order across all package READMEs for uniformity.🤖 Prompt for AI Agents