Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAVE_NETINET_IN_H as guard around header #765

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

diplfranzhoepfinger
Copy link
Contributor

Hi,

it does not make sense to have this in a config.h, and then still include it when HAVE_NETINET_IN_H is 0.

This fix solves this.

Copy link

cla-bot bot commented Aug 17, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Copy link
Contributor

@mhei mhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the changes make sense. But I'd prefer to have them all in a single commit. And please use a more verbose description instead of just "update ...". You can re-use the wording of the PR itself for example.

Hi,

it does not make sense to have this in a config.h, and then still include it when HAVE_NETINET_IN_H is 0.

This fix solves this.
Copy link

cla-bot bot commented Aug 18, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

@diplfranzhoepfinger
Copy link
Contributor Author

Yes, the changes make sense. But I'd prefer to have them all in a single commit. And please use a more verbose description instead of just "update ...". You can re-use the wording of the PR itself for example.

DONE

@stephane stephane merged commit ae6f327 into stephane:master Oct 21, 2024
1 check failed
@stephane
Copy link
Owner

Thank you @diplfranzhoepfinger (no need for CLA for such small changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants