Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oss-fuzz initialize #651

Closed
wants to merge 8 commits into from
Closed

Oss-fuzz initialize #651

wants to merge 8 commits into from

Conversation

0x34d
Copy link

@0x34d 0x34d commented Aug 12, 2022

For Everything related to oss-fuzz.

  1. create the project.
  2. create the fuzzer.
  3. run the fuzzer.
  4. reproduce bugs.

0x34d and others added 6 commits August 12, 2022 15:09
@cla-bot
Copy link

cla-bot bot commented Aug 12, 2022

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Signed-off-by: 0x34d <[email protected]>
@cla-bot
Copy link

cla-bot bot commented Aug 13, 2022

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Signed-off-by: 0x34d <[email protected]>
@cla-bot
Copy link

cla-bot bot commented Aug 13, 2022

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

@0x34d
Copy link
Author

0x34d commented Aug 14, 2022

Already signed it.

@0x34d
Copy link
Author

0x34d commented Aug 29, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 29, 2022
@cla-bot
Copy link

cla-bot bot commented Aug 29, 2022

The cla-bot has been summoned, and re-checked this pull request!

@stephane
Copy link
Owner

stephane commented Oct 3, 2022

@0x34d thank you for the PR but I'm sure that this fuzzer code will be abandoned once merged.
This code is only useful if maintained by people who know how to write fuzzing tests and it should be included in a CI.

@0x34d
Copy link
Author

0x34d commented Oct 4, 2022

I do understand. Well, fuzzing of project can be done by oss-fuzz. 
I will not give my words, but I can add some new targets. 
Can you hold the PR merge? 
These days I'm learning Autotools. 
So, compiling fuzzing targets can be done in a much easier way.

Regards Arjun.

@0x34d 0x34d closed this Oct 5, 2022
@0x34d 0x34d deleted the oss-fuzz branch October 6, 2022 10:25
@stephane
Copy link
Owner

stephane commented Dec 3, 2022

Hi @0x34d,

I merged #669 and now your work on libmodbus fuzzer is now part of your CI.
The last run (https://github.com/stephane/libmodbus/actions/runs/3567020621/jobs/5994200530) raised an issue about a non-existing directory (fuzz from https://github.com/google/oss-fuzz/blob/master/projects/libmodbus/build.sh#L18).

Could you have a look at the issue, please?

@0x34d
Copy link
Author

0x34d commented Dec 4, 2022

Yes, Fuzz is not available in the root dir of libmodbus.

There are two available fix:

  1. you merge the Oss fuzz files #658
  2. I make a New PR which have Fuzz dir init.

Update:
It should have failed there.

Step 5/6 : COPY fuzz/ $SRC/libmodbus/fuzz/

Give me 1-2 days, let me see what I can do.

@0x34d
Copy link
Author

0x34d commented Dec 4, 2022

well, my PR is working fine. google/oss-fuzz#9131
Merge this, then we will see. #658

@stephane
Copy link
Owner

stephane commented Dec 4, 2022

Sorry, I don't understand what you want to merge in libmodbus project between the closed PR and the external code :/

@0x34d
Copy link
Author

0x34d commented Dec 5, 2022

Alright, Let's start it again.

  1. we merge Oss fuzz files #658 in libmodbus
  2. we merge test libmodbus google/oss-fuzz#9131 with some fixes in oss-fuzz.

Possibly error that you are reporting will be gone.
https://github.com/stephane/libmodbus/actions/runs/3567020621/jobs/5994200530

I don't see any other option rather than that.

Arjun.

@stephane
Copy link
Owner

stephane commented Dec 5, 2022

Sorry but I don't want to merge code I'm not able to maintain (it contains zip files) and a different license.
The second point seems to delete files added by #658 :/

My goal here was to only fix the CI that uses the oss-fuzz branch but not merge the fuzz programs.

@0x34d
Copy link
Author

0x34d commented Dec 5, 2022

My goal here was to only fix the CI that uses the oss-fuzz branch but not merge the fuzz programs.

Well, in that case, open an issue in OSS-Fuzz.
Sorry, I'm not understanding what's going on and I'm unable to fix it.

Regards Arjun.

@0x34d
Copy link
Author

0x34d commented Dec 6, 2022

I hope this can help. 5dbb49a

@0x34d
Copy link
Author

0x34d commented Feb 8, 2023

Hi, stephane

The bug is in:

2022-11-28 17:10:47,428 - root - INFO - Running: docker run --rm --privileged --shm-size=2g --platform linux/amd64 -e FUZZING_ENGINE=libfuzzer -e CIFUZZ=True -e SANITIZER=address -e ARCHITECTURE=x86_64 -e FUZZING_LANGUAGE=c -e OUT=/github/workspace/build-out --volumes-from d96866fa1a2b gcr.io/oss-fuzz/libmodbus /bin/bash -c 'cp -r /src/libmodbus /github/workspace/storage/libmodbus'.
2022-11-28 17:10:47,968 - root - DEBUG - Stderr of command "git checkout -f f6689ba621d18a446ea2162079d9c84be246d310" is: Note: switching to 'f6689ba621d18a446ea2162079d9c84be246d310'.

when switching the branch. fuzz folder disappears.

 ---> 4be8994ab1eb
Step 5/6 : COPY fuzz/ $SRC/libmodbus/fuzz/

There are two way's to fix.

  1. merge Oss fuzz files #658
  2. Patch GitHub action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants