New functions to enable/disable various quirks (non-compliant) #533
+163
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlp
reviewed
Apr 21, 2020
|
WIP: I managed to run rtu tests and some of them failed, have to look into it. |
|
@karlp unit test fixed, I'll squash tiny changes once reviewed. |
Signed-off-by: Stéphane Raimbault <[email protected]> Signed-off-by: Michael Heimpold <[email protected]>
… tests before testing for quirks
|
commits squashed |
|
Related to Issue #38 |
|
Are there any remaining issues with this branch? I need the functionality for a project, I'd be willing to help out if there is anything that needs to be done to get it ready to merge |
stephane
added a commit
that referenced
this pull request
Oct 3, 2022
epsilonrt
pushed a commit
to epsilonrt/libmodbus
that referenced
this pull request
Jun 19, 2023
Useful functions when you are confronted with equipment which does not respect the protocol, which behaves strangely or when you wish to move away from the standard. Thank you @mhei for the great initial version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @stephane
I've got a device that can be only communicated using 'any address' 0xFE, which libmodbus refuses to do in a good will to comply to the standard. However, it is good to have an option to do so.
I have found a stale branch 'compliance' which was not merged and also an implementation from @mhei that I applied to the current master without any code changes.
Could this one be merged?
Please let me know if you need some changes in it.