RFC: Add fuzzing tests #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change int modbus_get_header_length(modbus_t *ctx) to unsigned int modbus_get_header_length(modbus_t *ctx) The result of modbus_get_header_length can never be negative and seems to be on signed due to a internal use of -1 in some places outside the public API This commit also follows the minimum number of signed -> unsigned changes without control flow changes.
This is a first attempt at adding a fuzzing harness to the test suite. It uses the "American Fuzzy Lop" (AFL) fuzzer and only requires a small harness to test a TCP ModBus server.
This enables the faster "clang-fast" compiler as well as better resting server state between runs.
stephane
added a commit
that referenced
this pull request
Nov 28, 2022
|
Closed by 96c06aa (in CI). |
epsilonrt
pushed a commit
to epsilonrt/libmodbus
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at adding a fuzzing harness to the test suite.
It uses the "American Fuzzy Lop" (AFL) fuzzer and only requires a small harness to test a TCP ModBus server.
I am seeking comments on what people think about adding a fuzzer to the test suite?