Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of box_pointers lint #733

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Aug 7, 2024

Presence of this lint in generated rust files causes warnings on beta.

(I use -Dwarnings in CI so noticed early.)

See rust-lang/rust#126018 for rationale. TL;DR: it's a useless lint.

@dpdresser
Copy link

Would love to see this merged

@robjtede
Copy link
Contributor Author

@stepancheg 2 weeks until this will start causing problems on stable

@stepancheg stepancheg merged commit 0dcd7e3 into stepancheg:master Aug 18, 2024
10 checks passed
@stepancheg
Copy link
Owner

Merged into a v3.5 branch, version 3.5.1 should be published in a day or so.

@stepancheg
Copy link
Owner

Thanks!

@robjtede robjtede deleted the rm-box_pointers branch August 18, 2024 21:52
sophokles73 added a commit to SoftwareDefinedVehicle/fleet-management-fork that referenced this pull request Oct 16, 2024
Updated minimum version of protobuf crate to fix clippy warning.
See stepancheg/rust-protobuf#733
sophokles73 added a commit to SoftwareDefinedVehicle/fleet-management-fork that referenced this pull request Oct 16, 2024
Updated minimum version of protobuf crate to fix clippy warning.
See stepancheg/rust-protobuf#733
eriksven pushed a commit to eclipse-sdv-blueprints/fleet-management that referenced this pull request Oct 16, 2024
Updated minimum version of protobuf crate to fix clippy warning.
See stepancheg/rust-protobuf#733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants