Make #[non_exhaustive] for oneofs configurable #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a configuration option to disable annotating generated enum types for proto `oneof`s with `#[non_exhaustive]`. The annotation makes sense for self-contained crates, but it's convenient to be able to turn it off. One use case is for larger projects that consist of multiple crates that are developed together. Being unable to exhaustively match on the contents of `oneof`s not just in the crate that includes the generated protobuf code is very useful.
|
Pr looks good, but can you please add a test? |
|
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration option to disable annotating generated enum types for proto
oneofs with#[non_exhaustive]. The annotation makes sense for self-contained crates, but it's convenient to be able to turn it off.One use case is for larger projects that consist of multiple crates that are developed together. Being unable to exhaustively match on the contents of
oneofs not just in the crate that includes the generated protobuf code is very useful.