Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for clearing fields by reflection #635

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

appaquet
Copy link
Contributor

Solves #627

@stepancheg
Copy link
Owner

Would you mind placing test in protobuf-test crate? With own proto file independent on descriptors.proto. Somewhere around common/v2 folder, so test would check it works for both syntax 2 and 3 (tests for v3 are copied from v2). Also if added to that folder tests will check that that it works with both protoc and pure parsers. Other than that, tests look good.

@stepancheg
Copy link
Owner

(Writing from the phone, so no links to sources.)

@appaquet appaquet force-pushed the feat/reflect-clear-field branch from f74f8ec to a441e4f Compare June 21, 2022 01:28
@appaquet
Copy link
Contributor Author

@stepancheg updated

@stepancheg stepancheg merged commit b6b6693 into stepancheg:master Jun 22, 2022
@stepancheg
Copy link
Owner

Published 3.1.0

@stepancheg
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants