Fix compute_size(value: &i32) for negative number #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king6cong
changed the title
king6cong
changed the title
king6cong
force-pushed
the
master
branch
2 times, most recently
from
005159f to
8f13250
Compare
stepancheg
requested changes
Jan 9, 2019
| @@ -22,6 +22,19 @@ fn test_map() { | |||
| test_serialize_deserialize_no_hex(&map); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_map_negative_int() { | |||
| fn test_map_negative_int() { | ||
| let mut map = TestMap::new(); | ||
| let mut entry = TestMapEntry::new(); | ||
| entry.set_v(10); |
There was a problem hiding this comment.
Seems to be not used anywhere.
| // See also: https://github.com/protocolbuffers/protobuf/blob/bd00671b924310c0353a730bf8fa77c44e0a9c72/src/google/protobuf/io/coded_stream.h#L1300-L1306 | ||
| if *value < 0 { | ||
| return 10 | ||
| } |
There was a problem hiding this comment.
A side note: length computation logic is duplicated between this function and call to i32::len_varint(). That code needs clean up (deduplication), but it may be not trivial, and I will do it later.
protobuf/src/stream.rs
Outdated
| @@ -790,14 +790,14 @@ impl<'a> CodedOutputStream<'a> { | |||
| self.position = 0; | |||
| }, | |||
| OutputTarget::Bytes => { | |||
| panic!("refresh_buffer must not be called on CodedOutputStream create from slice"); | |||
There was a problem hiding this comment.
Can you please split the patch into changes of logic and typo fixes? I appreciate doc fixes, and if you can't do it, I'll split the patch myself.
There was a problem hiding this comment.
changes moved here: #375
|
Updated 😄 |
|
Published versions 2.2.4, 2.1.5, 2.0.6 with fixes. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/io/coded_stream.h#L1300-L1306
Output verified by