Implement std::io traits for Coded*Streams #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepancheg
requested changes
Jun 28, 2017
protobuf/src/buf_read_iter.rs
Outdated
| @@ -242,7 +242,7 @@ impl<'ignore> BufReadIter<'ignore> { | |||
| } | |||
| } | |||
|
|
|||
| fn _read(&mut self, buf: &mut [u8]) -> ProtobufResult<usize> { | |||
| pub(crate) fn _read(&mut self, buf: &mut [u8]) -> ProtobufResult<usize> { | |||
There was a problem hiding this comment.
pub is enough, since BufReadIter is not an exported type.
Could you rename function to read, without underscore please?
protobuf/src/stream.rs
Outdated
| @@ -1,6 +1,7 @@ | |||
| use std::mem; | |||
| use std::io::{BufRead, Read}; | |||
| use std::io::Write; | |||
| use std::io::Result as IOResult; | |||
There was a problem hiding this comment.
use std::io and then io::Result I think would be better.
protobuf/src/stream.rs
Outdated
| } | ||
|
|
||
| fn flush(&mut self) -> IOResult<()> { | ||
| self.flush().map_err(Into::into) |
There was a problem hiding this comment.
CodedOutputStream::flush(self) would be clearer I think to make sure that there is no recursion here.
|
@stepancheg done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229.