Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use underscore to escape keywords #618

Closed
Tracked by #518
stepancheg opened this issue Apr 29, 2022 · 0 comments
Closed
Tracked by #518

Use underscore to escape keywords #618

stepancheg opened this issue Apr 29, 2022 · 0 comments
Labels
rust-protobuf-v3 Issued to be fixed to release version 3

Comments

@stepancheg
Copy link
Owner

stepancheg commented Apr 29, 2022 •
edited
Loading

In version 2 identifiers are escaped with prefixes like message_ or enum_.

The plan was to use raw identifiers for keywords, but not all keywords can be made raw identifiers.

So now the plan is to use _ suffix to escape everything.
@stepancheg stepancheg added the rust-protobuf-v3 Issued to be fixed to release version 3 label Apr 29, 2022
@stepancheg stepancheg mentioned this issue Apr 29, 2022
Closed
12 tasks
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Do not escape module name in generated code
bb2ed61 
Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Use underscore suffix to escape identifiers which are keywords
94e968d 
Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Use underscore to escape message or enum names
2094138 
Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Use _ to escape field names
0d922e3 
Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Do not add underscore to accessors of field names which are keywords
8f59fa5 
E. g. for message field `fn`, rust field is `fn_`, but setter should
be `set_fn`, not `set_fn_`.

Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Escape enum variants with underscore suffix
633b9e5 
Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Escape module names with underscope suffix
d88db7a 
instead of `_pb` suffix.

Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Regenerate protos
5676296 
Issue #618
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Explain why we use underscore escape
e912cdd 
Issue #618
@stepancheg stepancheg changed the title Use raw identifiers for reserved words Use underscore to escape keywords Apr 29, 2022
stepancheg added a commit that referenced this issue Apr 29, 2022
@stepancheg
Missing files after renames
e81c459 
Issue #618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Do not escape module name in generated code
843a5d6 
Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Use underscore suffix to escape identifiers which are keywords
513a0cd 
Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Use underscore to escape message or enum names
84189af 
Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Use _ to escape field names
c6b1a07 
Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Do not add underscore to accessors of field names which are keywords
4f014c7 
E. g. for message field `fn`, rust field is `fn_`, but setter should
be `set_fn`, not `set_fn_`.

Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Escape enum variants with underscore suffix
644239a 
Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Escape module names with underscope suffix
2353435 
instead of `_pb` suffix.

Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Regenerate protos
c5ec5e4 
Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Explain why we use underscore escape
5c8a9a1 
Issue stepancheg#618
akhramov pushed a commit to cognitedata/rust-protobuf that referenced this issue Jan 5, 2024
@stepancheg @akhramov
Missing files after renames
0281f3c 
Issue stepancheg#618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rust-protobuf-v3 Issued to be fixed to release version 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stepancheg