Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc_rust does not handle file path with backslashes properly on windows. #356

Closed
dvush opened this issue Dec 13, 2018 · 3 comments
Closed

Comments

@dvush
Copy link

dvush commented Dec 13, 2018

Hi.

It seems that protoc_rust does not handle slashes in paths correctly.
If you pass valid path on windows(with "") to protoc_rust::run it won't work.

example that does not work on windows https://github.com/dvush/protoc_path_buf.git

@stepancheg
Copy link
Owner

I've set up travis-ci on Windows: https://travis-ci.org/stepancheg/rust-protobuf/builds/469847927

This is the first step.

Next steps are:

  • fix the build
  • reproduce and fix the issue you've reported

(You can send PR of course, but I cannot fix it myself without CI, I don't have a Windows box)

@stepancheg
Copy link
Owner

OK, the problem is reproduced on Windows in CI: https://travis-ci.org/stepancheg/rust-protobuf/jobs/470187677 now need to fix it.

stepancheg added a commit that referenced this issue Dec 26, 2018
stepancheg added a commit that referenced this issue Dec 26, 2018
stepancheg added a commit that referenced this issue Dec 26, 2018
stepancheg added a commit that referenced this issue Dec 29, 2018
@stepancheg
Copy link
Owner

Should be fixed now. Published v2.2.2. Please reopen if the problem still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants