Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single quotes in strings break the pure codegen parser #337

Closed
emily33901 opened this issue Sep 19, 2018 · 2 comments
Closed

single quotes in strings break the pure codegen parser #337

emily33901 opened this issue Sep 19, 2018 · 2 comments

Comments

@emily33901
Copy link

emily33901 commented Sep 19, 2018

Example:

import "google/protobuf/descriptor.proto";

extend .google.protobuf.MethodOptions {
	optional string method_description = 50000;
}

message test_message {
    optional string a = 1 [default = "this won't parse"];
}

service test {
    rpc NiceFunction (Map<int32, string>) returns (int32) {
        option (method_description) = "Does nothing and doesn't care";
    }
}

and gives error

error: ParserErrorWithLocation(ParserErrorWithLocation { error: InternalError, line: 8, col: 48 })

using protobuf-codegen-pure = "2.0.4"

Am I missing something obvious?

stepancheg added a commit that referenced this issue Sep 21, 2018
stepancheg added a commit that referenced this issue Sep 21, 2018
@stepancheg
Copy link
Owner

Published fix as 2.0.5. Thanks!

@emily33901
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants