Ignore error of flush in Drop of CodedOutputStream

#714
stepancheg · Feb 25, 2024 · c1c937b · c1c937b
1 parent b14c8bd
commit c1c937b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/protobuf/src/coded_output_stream/mod.rs b/protobuf/src/coded_output_stream/mod.rs
@@ -1010,8 +1010,9 @@ impl<'a> Write for CodedOutputStream<'a> {
 
 impl<'a> Drop for CodedOutputStream<'a> {
     fn drop(&mut self) {
-        // This may panic
-        CodedOutputStream::flush(self).expect("failed to flush");
+        // User must call `flush` to guarantee that the data is written.
+        // Rust should have a lint to enforce `flush` call before drop.
+        let _ignore = CodedOutputStream::flush(self);
     }
 }