Merge pull request #25 from william-hutchison/upgrade-gating

Upgrade gating
stemangiola · May 20, 2024 · 08bbefc · 08bbefc
2 parents 858a4d3 + 5cf2c0f
commit 08bbefc
Show file tree

Hide file tree

Showing 18 changed files with 16 additions and 17 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: tidygate
 Type: Package
 Title: Add Gate Information to Your Tibble
-Version: 0.5.2
+Version: 0.5.3
 Authors@R: 
     c(person(given = "Stefano",
            family = "Mangiola",

diff --git a/R/functions_OLD.R b/R/functions_OLD.R
@@ -356,7 +356,8 @@ gate_programmatic <-
            .dim1,
            .dim2, 
            gate_list,
-           name = "gate") {
+           name = "gate", 
+           ...) {
 
     # Comply with CRAN NOTES
     . = NULL

diff --git a/R/functions_chr_int.R b/R/functions_chr_int.R
@@ -265,7 +265,6 @@ pretty_plot_chr_int = function(.data,
 #' @param .size A column symbol. Size of points
 #' @param opacity A number between 0 and 1. The opacity level of the data points
 #' @param how_many_gates An integer. The number of gates to label
-#' @param gate_list A list of gates. It is returned by gate function as attribute \"gate\". If you want to create this list yourself, each element of the list is a data frame with x and y columns. Each row is a coordinate. The order matter.
 #' @param ... Further parameters passed to the function gatepoints::fhs
 #'
 #' @return A tibble with additional columns
@@ -379,7 +378,8 @@ gate_programmatic_chr_int <-
   function(.data,
            .dim1,
            .dim2,
-           gate_list
+           gate_list,
+           ...
            ) {
     # Comply with CRAN NOTES
     . = NULL

diff --git a/R/gate_app.R b/R/gate_app.R
@@ -34,6 +34,12 @@ server <-
 
     output$plot <- plotly::renderPlotly({
 
+      # Fix CRAN NOTES
+      .key <- NULL
+      .selected <- NULL
+      dimension_x <- NULL
+      dimension_y <- NULL
+
       # Begin recording selection and brush information
       select_data <- plotly::event_data("plotly_selected")
       brush_data <- plotly::event_data("plotly_brushed")

diff --git a/R/methods.R b/R/methods.R
@@ -276,6 +276,9 @@ gate_custom <-
 
     message("tidygate says: this feature is in early development and may undergo changes or contain bugs.")
 
+    # Fix CRAN NOTES
+    key <- NULL
+
     # Create tibble with .key column
     data <- 
       custom_plot |>

diff --git a/man/figures/lifecycle-archived.svg b/man/figures/lifecycle-archived.svg
diff --git a/man/figures/lifecycle-defunct.svg b/man/figures/lifecycle-defunct.svg
diff --git a/man/figures/lifecycle-deprecated.svg b/man/figures/lifecycle-deprecated.svg
diff --git a/man/figures/lifecycle-experimental.svg b/man/figures/lifecycle-experimental.svg
diff --git a/man/figures/lifecycle-maturing.svg b/man/figures/lifecycle-maturing.svg
diff --git a/man/figures/lifecycle-questioning.svg b/man/figures/lifecycle-questioning.svg
diff --git a/man/figures/lifecycle-soft-deprecated.svg b/man/figures/lifecycle-soft-deprecated.svg
diff --git a/man/figures/lifecycle-stable.svg b/man/figures/lifecycle-stable.svg
diff --git a/man/figures/lifecycle-superseded.svg b/man/figures/lifecycle-superseded.svg
diff --git a/man/gate-methods.Rd b/man/gate-methods.Rd
diff --git a/man/gate_interactive_chr_int.Rd b/man/gate_interactive_chr_int.Rd
diff --git a/man/gate_programmatic.Rd b/man/gate_programmatic.Rd
diff --git a/man/gate_programmatic_chr_int.Rd b/man/gate_programmatic_chr_int.Rd