Repository navigation
Update suitesparse's find module scripts - #1
stellaraccident merged 1 commit into
Conversation
hipSOLVER's find module scripts (for suitesparse) were using `find_path` on name `suitesparse/cholmod.h` instead of `cholmod.h`, which allowed hipSOLVER to `#include <suitesparse/cholmod.h>`. This commit updates the aforementioned cmake scripts, to honour the way `Suitesparse::CHOLMOD` advertises its include directories.
|
@stellaraccident, this works in my own reproducer. Would you mind merging those changes if you are happy with them? |
|
Just checking because the project settings seem to allow any merge option. We do squash and merge here? |
|
In hipsolver itself we squash and merge, and I personally also tend to squash and merge any time I have the option. But since this is a PR on your PR, I think that you can go any way you prefer. :) |
Ok. Most projects I've seen have strong feelings on that and even have the settings set to exclude other options. Letting the general public decide is usually a recipe for getting your history cluttered with "Fix typo again" style commits |
hipSOLVER's find module scripts (for suitesparse) were using `find_path` on name `suitesparse/cholmod.h` instead of `cholmod.h`, which allowed hipSOLVER to `#include <suitesparse/cholmod.h>`. This commit updates the aforementioned cmake scripts, to honour the way `Suitesparse::CHOLMOD` advertises its include directories.
hipSOLVER's find module scripts (for suitesparse) were using
find_pathon namesuitesparse/cholmod.hinstead ofcholmod.h, which allowed hipSOLVER to#include <suitesparse/cholmod.h>.This commit updates the aforementioned cmake scripts, to honour the way
Suitesparse::CHOLMODadvertises its include directories.