-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate data to new transactions table #207
Conversation
c1011cd
to
daf4ca8
Compare
123755d
to
331e630
Compare
331e630
to
7b40026
Compare
7b40026
to
8f3abca
Compare
@2opremio overall looks good! Could you add some tests? |
@tamirms Sure thing! |
ee26069
to
9e581ab
Compare
966ac43
to
ce7194d
Compare
0c7fc5c
to
3f4ca3f
Compare
Uhm, I am starting to think it's a problem with the JSONRPC client. If I print the listening ports right after the error, I see that soroban RPC is indeed listening on port 8000
I think that the client may not retry after the first attempt if it cannot connect :S |
bca6f2c
to
5c4c87e
Compare
@tamirms This is finally ready to go. The new migration test required rewriting most of the integration-test infra, so the PR ended up getting quite big (sorry about that). As a result the integration test infra is way cleaner. BTW, the spurious test failures I was fighting were due to creachadair/jrpc2#118 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job debugging creachadair/jrpc2#118 , this looks great!
Also, create data migration infrastructure so that future migrations can be easily added.