Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Social Login(OAuth Authentication) #171

Open
wants to merge 4 commits into
base: update-P21
Choose a base branch
from

Conversation

Dprof-in-tech
Copy link

@Dprof-in-tech Dprof-in-tech commented Aug 4, 2024

closes #162

This is a rough implementation of the issue solution and i need your review to perfect it.

Below is a media file showing the implementation of this solution

Screencast.from.2024-08-04.11-31-19.webm

@Dprof-in-tech Dprof-in-tech changed the title ODHack: Implement Social Login(OAuth Authentication) #162 Implement Social Login(OAuth Authentication) Aug 4, 2024
@Julian-dev28
Copy link
Contributor

NICELY DONE!

This is a great implementation on Oauth in Stellar dapps and I believe that this PR provides a solid foundation for future implementations.

As it stands, users can log in with a social which is a great first step. The next objective is to:

  • implement signing txs with Oauth generated accounts.

Would you like to complete the task for a higher award? or would you like to submit your PR as is?

@Dprof-in-tech
Copy link
Author

Dprof-in-tech commented Aug 14, 2024 via email

@Julian-dev28
Copy link
Contributor

Great! Have at it then and please try to complete the task by the end of the week. If not, I will award regardless but I will have to close the ticket out by Friday.

Thanks!

@Dprof-in-tech
Copy link
Author

Dprof-in-tech commented Aug 14, 2024 via email

@Julian-dev28
Copy link
Contributor

Closing this one out!

Thanks again for the awesome work! I hope to see you at the next hackathon!

@Julian-dev28
Copy link
Contributor

Julian-dev28 commented Aug 17, 2024

@Dprof-in-tech I am re-opening this bounty for further work! SDF has awarded you for the work you've done so far and will add can add an additional award for implementing signing txs with Oauth generated accounts.

@Dprof-in-tech
Copy link
Author

Dprof-in-tech commented Aug 17, 2024 via email

@Dprof-in-tech
Copy link
Author

Screenshot from 2024-08-18 14-49-16
Screenshot from 2024-08-18 14-48-35
Screenshot from 2024-08-18 14-48-22
Screenshot from 2024-08-18 14-48-09

i've worked on it and now creates a wallet account with the keys generated and connects to them when signed in.

I'm having a bit of trouble testing it out following that i cant donate to pledge as shown on my screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants