-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Social Login(OAuth Authentication) #171
base: update-P21
Are you sure you want to change the base?
Conversation
NICELY DONE! This is a great implementation on Oauth in Stellar dapps and I believe that this PR provides a solid foundation for future implementations. As it stands, users can log in with a social which is a great first step. The next objective is to:
Would you like to complete the task for a higher award? or would you like to submit your PR as is? |
I would love to finish up the task so it’s complete instead of halfway done
chief
…On Wed, Aug 14, 2024 at 12:23 AM Julian Martinez ***@***.***> wrote:
NICELY DONE!
This is a great implementation on Oauth in Stellar dapps and I believe
that this PR provides a solid foundation for future implementations.
As it stands, users can log in with a social which is a great first step.
The next objective is to:
- implement signing txs with Oauth generated accounts.
Would you like to complete the task for a higher award? or would you like
to submit your PR as is?
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3W3TPPPJLDJQXZEAQHWIU3ZRKIPTAVCNFSM6AAAAABL6XCYA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBXGM3TONBZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Great! Have at it then and please try to complete the task by the end of the week. If not, I will award regardless but I will have to close the ticket out by Friday. Thanks! |
Will do, thanks!
…On Wed, Aug 14, 2024 at 6:06 PM Julian Martinez ***@***.***> wrote:
Great! Have at it then and please try to complete the task by the end of
the week. If not, I will award regardless but I will have to close the
ticket out by Friday.
Thanks!
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3W3TPKJWGAQQAWOXBT3M7TZROFC7AVCNFSM6AAAAABL6XCYA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGMZTMNZQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Closing this one out! Thanks again for the awesome work! I hope to see you at the next hackathon! |
@Dprof-in-tech I am re-opening this bounty for further work! SDF has awarded you for the work you've done so far and will add can add an additional award for implementing signing txs with Oauth generated accounts. |
Thank you so much for the great news!
Let me work on finishing up
…On Sat, Aug 17, 2024 at 3:12 AM Julian Martinez ***@***.***> wrote:
@Dprof-in-tech <https://github.com/Dprof-in-tech> I am re-opening this
bounty for further work! SDF has awarded you via OnlyDust for the work
you've done so far and we look forward more improvements!
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3W3TPK73EBDRKWJV4VK34LZR2WRHAVCNFSM6AAAAABL6XCYA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJUGU2DEMBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
closes #162
This is a rough implementation of the issue solution and i need your review to perfect it.
Below is a media file showing the implementation of this solution
Screencast.from.2024-08-04.11-31-19.webm