Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison fixes #762

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Comparison fixes #762

merged 3 commits into from
Apr 11, 2023

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 10, 2023

What

Three patches toward making Compare<RawVal> for Env and Compare<ScVal> for Budget behave identically to Ord for ScVal, per #743.

These are the initial patches described in my comment here: #743 (comment)

Why

As discussed in that issue, all three of Compare<RawVal> for Env, Compare<ScVal> for Budget and Ord for ScVal need to behave the same. These patches fix the first three discrepancies I have found through fuzzing.

Known limitations

This adds some hand-written unit tests to prevent regressions, but I intend to add comprehensive proptests / fuzz tests to the soroban-sdk crate eventually. Such tests depend on some fuzzing-related patches that are not yet ready to land.

Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@graydon graydon merged commit 5c7c415 into stellar:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants