Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liquidity pool effect types to their correct values. #723

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Update liquidity pool effect types to their correct values. #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc2402b
Update effect types to correct values
Shaptic Nov 10, 2021
cefc4ed
Fix changelog entry
Shaptic Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,18 @@ A breaking change will get clearly marked in this log.

## Unreleased

### Fix

- Fixes the `type_i` enumeration field to accurately reflect liquidity pool effects ([#723](https://github.com/stellar/js-stellar-sdk/pull/723)).

### Updates

- Updates the following SEP-10 utility functions to include [client domain verification](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0010.md#verifying-the-client-domain) functionality ([#720](https://github.com/stellar/js-stellar-sdk/pull/720)):
- Updated `Utils.buildChallengeTx()` to accept the `clientDomain` and `clientSigningKey` optional parameters
- Updated `Utils.readChallengeTx()` to parse challenge transactions containing a `client_domain` ManageData operation
- Updated `Utils.verifyChallengeTxSigners()` to verify an additional signature from the `clientSigningKey` keypair if a `client_domain` Manage Data operation is included in the challenge


## [v9.0.0](https://github.com/stellar/js-stellar-sdk/compare/v9.0.0-beta.1...v9.0.0)

This stable release adds **support for Protocol 18**. For details, you can refer to [CAP-38](https://stellar.org/protocol/cap-38) for XDR changes and [this document](https://docs.google.com/document/d/1pXL8kr1a2vfYSap9T67R-g72B_WWbaE1YsLMa04OgoU/view) for changes to the Horizon API.
Expand Down
14 changes: 8 additions & 6 deletions src/types/effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,15 @@ export enum EffectType {
signer_sponsorship_created = 72,
signer_sponsorship_updated = 73,
signer_sponsorship_removed = 74,
// clawback effects
claimable_balance_clawed_back = 80,
liquidity_pool_deposited = 81,
liquidity_pool_withdrew = 82,
liquidity_pool_trade = 83,
liquidity_pool_created = 84,
liquidity_pool_removed = 85,
liquidity_pool_revoked = 86,
// liquidity pool effects
liquidity_pool_deposited = 90,
liquidity_pool_withdrew = 91,
liquidity_pool_trade = 92,
liquidity_pool_created = 93,
liquidity_pool_removed = 94,
liquidity_pool_revoked = 95,
}
export interface BaseEffectRecord extends Horizon.BaseResponse {
id: string;
Expand Down