chore: use requestAirdrop to fund e2e accounts
#1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
approved these changes
Dec 18, 2024
chadoh
force-pushed
the
chore/fund-with-requestAirdrop
branch
2 times, most recently
from
719f595 to
cbe5d7a
Compare
@willemneal [pointed out](stellar/stellar-docs#1101 (review)) that it's a bit of a bummer to create accounts with a pure-SDK interface just to revert to `fetch` and a hard-coded Friendbot URL in order to fund that account. This uses `rpc.Server#requestAirdrop` to do the funding. I find the name of this method a bit unexpected! I wonder if the language here has evolved since the method was first added.
chadoh
force-pushed
the
chore/fund-with-requestAirdrop
branch
from
cbe5d7a to
95bbfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@willemneal pointed out that it's a bit of a bummer to create accounts with a pure-SDK interface just to revert to
fetchand a hard-coded Friendbot URL in order to fund that account.This uses
rpc.Server#requestAirdropto do the funding.I find the name of this method a bit unexpected! I wonder if the language here has evolved since the method was first added.