Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove init-genesis-state command #5504

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

karthikiyer56
Copy link
Contributor

@karthikiyer56 karthikiyer56 commented Nov 5, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • [x ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • [x ] This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This PR is related to issue #5469
The init-genesis-state functionality and all the accompanying logic and tests are removed as a part of this PR

Why

Refer #5469 for more details

@karthikiyer56 karthikiyer56 marked this pull request as draft November 5, 2024 00:20
@karthikiyer56 karthikiyer56 marked this pull request as ready for review November 5, 2024 05:10
@karthikiyer56 karthikiyer56 requested a review from a team November 5, 2024 05:11
@karthikiyer56 karthikiyer56 force-pushed the karthik/5469/deprecate-init-genesis-state branch from 3c68fd2 to e6b26a8 Compare November 5, 2024 20:17
@karthikiyer56 karthikiyer56 enabled auto-merge (squash) November 5, 2024 22:00
@karthikiyer56 karthikiyer56 merged commit 39a8d36 into master Nov 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants