services/horizon: Issue #3241, Include unauthorized assets on /assets #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
reviewed
Mar 8, 2021
services/horizon/internal/ingest/processors/asset_stats_processor.go
Outdated
Show resolved
Hide resolved
paulbellamy
force-pushed
the
3241/assets-unauthorized
branch
from
523d12f to
66cf1ae
Compare
services/horizon/internal/db2/schema/migrations/43_asset_stat_trust_line_flags.sql
Outdated
Show resolved
Hide resolved
bartekn
reviewed
Mar 18, 2021
|
Per discussion, for now, I think let's leave out the query param for filtering. The output is not super verbose so it's probably not that useful. |
paulbellamy
force-pushed
the
3241/assets-unauthorized
branch
from
d2672bc to
dedc983
Compare
paulbellamy
changed the title
paulbellamy
force-pushed
the
3241/assets-unauthorized
branch
3 times, most recently
from
544eb70 to
82f69d9
Compare
paulbellamy
changed the title
tamirms
reviewed
Mar 21, 2021
tamirms
reviewed
Mar 21, 2021
tamirms
reviewed
Mar 21, 2021
bartekn
approved these changes
Mar 22, 2021
services/horizon/internal/ingest/processors/asset_stats_processor.go
Outdated
Show resolved
Hide resolved
services/horizon/internal/ingest/processors/asset_stats_processor.go
Outdated
Show resolved
Hide resolved
services/horizon/internal/db2/schema/migrations/44_asset_stat_accounts_and_balances.sql
Show resolved
Hide resolved
added 14 commits
March 22, 2021 13:42
Co-authored-by: Bartek Nowotarski <[email protected]>
Co-authored-by: Bartek Nowotarski <[email protected]>
paulbellamy
force-pushed
the
3241/assets-unauthorized
branch
from
8323c26 to
49b9399
Compare
This was referenced Mar 22, 2021
7 tasks
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Include unauthorized assets on the /assets endpoint, and expose the trustline flags.
Why
As per issue #3241.
Known limitations
[TODO or N/A]