{backend, test}: change backend files and backend tests to typescript #204
Conversation
|
Something went wrong with PR preview build please check |
|
Something went wrong with PR preview build please check |
|
Something went wrong with PR preview build please check |
# Conflicts: # README.md # backend/app.js # backend/routes.js # backend/routes.ts # package.json # test/tests/integration/backend.ts # tsconfig.json # yarn.lock
|
Something went wrong with PR preview build please check |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
| }, | ||
| ); | ||
|
|
||
| export const NodeMeasurement = sequelize.define( |
There was a problem hiding this comment.
removed this NodeMeasurement table, it's not being used
| @@ -38,7 +38,7 @@ | |||
| "babel-preset-es2015": "^6.22.0", | |||
| "babel-preset-react": "^6.23.0", | |||
| "babel-register": "^6.24.0", | |||
| "bignumber.js": "^3.0.1", | |||
| "bignumber.js": "^9.0.1", | |||
There was a problem hiding this comment.
bignumber.js types added in version 4
tsconfig.json
Outdated
| "compilerOptions": { | ||
| // temporary flags during js->ts transition | ||
| "allowJs": false, | ||
| "allowJs": true, | ||
| "isolatedModules": false, | ||
|
|
||
| "target": "es5", | ||
| "rootDir": "./backend", | ||
| "baseUrl": "./" | ||
| "target": "es6", |
There was a problem hiding this comment.
changing target to es6 because of sequelize
acharb
changed the title
acharb
changed the title
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
WHAT
converting backend files from JS to TS. Some slight refactoring was needed (pointed out in comments), but in general no functional changes.
closes #197
WHY
Typescript will make the project more aligned with other SDF ones, as well as prevent bugs thanks to TS compiler