Configurable workday tick appearance - #2950
Conversation
…y-ticks # Conflicts: # Tests/CodexBarTests/ProviderArchitectureGatekeeperTests.swift
…y-ticks # Conflicts: # CHANGELOG.md
|
🦞👀 Pull request received. I will update this pull request when review starts. |
clawsweeper
Bot
added
merge-risk: 🚨 compatibility
|
Codex review: needs maintainer review before merge. Reviewed August 16, 2026, 12:00 AM ET / 04:00 UTC. ClawSweeper reviewWhat this changesAdds a setting to hide, preserve, or increase the contrast of workday boundary ticks in weekly usage bars. Merge readinessKeep open for maintainer product direction. The implementation is coherent and does not show a concrete correctness or security defect, but it adds a permanent synced configuration surface. Priority: P3 Review scores
Verification
How this fits togetherCodexBar derives weekly usage-bar models from provider data and user settings, then renders them in the menu and provider-detail views. This PR threads a tick-appearance preference through local storage and CloudKit sync into those renderers. flowchart LR
A[Provider usage] --> B[Weekly usage model]
C[Local and Cloud preferences] --> D[Tick appearance]
D --> B
B --> E[Usage-bar renderer]
E --> F[Menu and provider details]
Decision needed
Why: The code preserves the current default, but whether this visual preference should become lasting local and CloudKit product surface requires maintainer intent. Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: If product direction is approved, retain the subtle default and optional sync decoding so upgrades and older payloads remain compatible; otherwise keep the existing fixed presentation. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new visual preference rather than repairing a failing existing behavior. Is this the best way to solve the issue? Unclear: the implementation is a narrow path that preserves the current default, but maintainers must first choose whether the permanent synced setting is desirable. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 823f6b7c4ec8. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
# Conflicts: # CHANGELOG.md
2 participants
Summary
Adds configurable workday boundary tick visibility and contrast for weekly usage bars.
Closes #2904.
Changes
Screenshots
Each picture includes the option toggled on the left side, and the resulting ticks on the right side (Codex shown).
Menu option (dropdown)
Subtle (default)
High contrast
Hidden
Testing
make checkmake test— 860 selections across 72 groups passed before the final visual-only thickness adjustment.