Skip to content

Fix localized session equivalents - #2421

Closed
Yuxin-Qiao wants to merge 1 commit into
steipete:mainfrom
Yuxin-Qiao:codex/fix-localized-plurals
Closed

Fix localized session equivalents#2421
Yuxin-Qiao wants to merge 1 commit into
steipete:mainfrom
Yuxin-Qiao:codex/fix-localized-plurals

Conversation

@Yuxin-Qiao

Copy link
Copy Markdown
Contributor

Summary

  • format session-equivalent plural strings with the locale of the resource bundle selected by L
  • keep application-language fallbacks and plural rules aligned
  • add regression coverage for resource-locale fallback

Why

When the system locale and the selected or fallback application language differ, the previous formatter could use plural rules from one language with strings from another. For example, English could render 1 windows instead of 1 window.

Validation

  • focused Swift test filter for SessionEquivalentForecastTests and LocalizationBundleCacheTests: 43 tests passed
  • make check: passed
  • full make test: the prior SessionEquivalentForecastTests failure is fixed; the run now reaches group 49 and stops on unrelated Spend Dashboard test isolation failures. Existing test(repo-hygiene): restore macOS test baseline #2418 addresses the Controller subset; remaining Token Provenance coverage will be kept separate.

UI proof

Not applicable: localized text behavior is covered by deterministic unit tests.

Provider / privacy

No provider access, credentials, account data, or network behavior changed.

@clawsweeper

clawsweeper Bot commented Jul 23, 2026

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix localized session equivalents This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@Yuxin-Qiao

Copy link
Copy Markdown
Contributor Author

Superseded by #2418, which now contains this localized plural fix together with the complete macOS test-baseline restoration and full validation.

@Yuxin-Qiao Yuxin-Qiao closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant