Skip to content

Stabilize dashboard fixture clock #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steipete merged 2 commits into from
Jul 28, 2026
Merged

Stabilize dashboard fixture clock #2390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4576313
Stabilize dashboard fixture clock
ProspectOre Jul 22, 2026
b7caf56
Merge remote-tracking branch 'origin/main' into pr-2390-land
steipete Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 25 additions & 38 deletions Tests/CodexBarTests/SpendDashboardControllerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,7 @@ struct SpendDashboardControllerTests {
let snapshot = Self.input(id: "claude", provider: .claude, cost: 3).snapshot
store._setTokenSnapshotForTesting(snapshot, provider: .claude)
store._test_tokenUsageRefreshOverride = { _, _ in }
let controller = SpendDashboardController(userDefaults: settings.userDefaults, requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let controller = Self.dashboardController(settings: settings, store: store)

let baselineConfiguration = SpendDashboardSource.configuration(settings: settings, store: store)
controller.update(configuration: baselineConfiguration)
Expand Down Expand Up @@ -409,11 +407,7 @@ struct SpendDashboardControllerTests {
environmentBase: [:])
store._setTokenSnapshotForTesting(Self.input(provider: .claude, cost: 3).snapshot, provider: .claude)
store._test_tokenUsageRefreshOverride = { _, _ in }
let controller = SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let controller = Self.dashboardController(settings: settings, store: store)

let firstConfiguration = SpendDashboardSource.configuration(settings: settings, store: store)
controller.update(configuration: firstConfiguration)
Expand All @@ -434,11 +428,7 @@ struct SpendDashboardControllerTests {
#expect(controller.failedSourceCount == 1)
#expect(store.tokenSnapshot(for: .claude)?.last30DaysCostUSD == 3)

let reopenedController = SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let reopenedController = Self.dashboardController(settings: settings, store: store)
reopenedController.update(configuration: replacementConfiguration)
await Self.waitUntil { !reopenedController.isRefreshing }
#expect(reopenedController.model.groups.isEmpty)
Expand Down Expand Up @@ -492,11 +482,7 @@ struct SpendDashboardControllerTests {

store._setTokenSnapshotForTesting(Self.input(provider: .mistral, cost: 3).snapshot, provider: .mistral)
store._test_providerRefreshOverride = { _ in }
let controller = SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let controller = Self.dashboardController(settings: settings, store: store)
controller.update(configuration: selectedBackupConfiguration)
await Self.waitUntil { !controller.isRefreshing }
#expect(controller.model.groups.first?.totalCost == 3)
Expand Down Expand Up @@ -534,11 +520,7 @@ struct SpendDashboardControllerTests {
environmentBase: [:])
store._setTokenSnapshotForTesting(Self.input(provider: .claude, cost: 4).snapshot, provider: .claude)
store._test_tokenUsageRefreshOverride = { _, _ in }
let controller = SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let controller = Self.dashboardController(settings: settings, store: store)
controller.update(configuration: SpendDashboardSource.configuration(settings: settings, store: store))
await Self.waitUntil { !controller.isRefreshing }
#expect(controller.model.groups.first?.totalCost == 4)
Expand Down Expand Up @@ -566,11 +548,7 @@ struct SpendDashboardControllerTests {
environmentBase: [:])
store._setTokenSnapshotForTesting(Self.input(provider: .claude, cost: 5).snapshot, provider: .claude)
store._test_tokenUsageRefreshOverride = { _, _ in }
let controller = SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let controller = Self.dashboardController(settings: settings, store: store)
let firstConfiguration = SpendDashboardSource.configuration(settings: settings, store: store)
controller.update(configuration: firstConfiguration)
await Self.waitUntil { !controller.isRefreshing }
Expand Down Expand Up @@ -637,11 +615,7 @@ struct SpendDashboardControllerTests {
environmentBase: [:])
store._setTokenSnapshotForTesting(Self.input(provider: .claude, cost: 5).snapshot, provider: .claude)
store._test_tokenUsageRefreshOverride = { _, _ in }
let controller = SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let controller = Self.dashboardController(settings: settings, store: store)
controller.update(configuration: SpendDashboardSource.configuration(settings: settings, store: store))
await Self.waitUntil { !controller.isRefreshing }
#expect(controller.model.groups.first?.totalCost == 5)
Expand All @@ -657,11 +631,7 @@ struct SpendDashboardControllerTests {
#expect(controller.model.groups.isEmpty)
#expect(controller.failedSourceCount == 1)

let reopenedController = SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(settings: settings, store: store, mode: mode)
})
let reopenedController = Self.dashboardController(settings: settings, store: store)
reopenedController.update(configuration: reenabledConfiguration)
await Self.waitUntil { !reopenedController.isRefreshing }
#expect(reopenedController.model.groups.isEmpty)
Expand Down Expand Up @@ -783,6 +753,23 @@ struct SpendDashboardControllerTests {
#expect(controller.selectedDays == 30)
}

private static let fixtureNow = Date(timeIntervalSince1970: 1_784_179_200)

private static func dashboardController(
settings: SettingsStore,
store: UsageStore) -> SpendDashboardController
{
SpendDashboardController(
userDefaults: settings.userDefaults,
requestBuilder: { mode in
await SpendDashboardSource.makeRequest(
settings: settings,
store: store,
mode: mode,
now: Self.fixtureNow)
})
}

private static func controller(gate: SpendDashboardLoaderGate) -> SpendDashboardController {
let controllerBox = SpendDashboardControllerBox()
let captureStore = SpendDashboardCapturedInputStore()
Expand Down